Bug 1897830: Fix cluster creation when using localvolume #7552

afreen23 · 2020-12-15T11:23:09Z

use the nodeSelector field to get the associated nodes for a PV
drops the usage of labels for pv association

Before:

After:

- use the nodeSelector field to get the associated nodes for a PV - drops the usage of labels Signed-off-by: Afreen Rahman <afrahman@redhat.com>

openshift-ci-robot · 2020-12-15T11:23:14Z

@afreen23: This pull request references Bugzilla bug 1897830, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1897830: Fix cluster creation when using localvolume

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

afreen23 · 2020-12-15T11:42:26Z

/bugzilla refresh

openshift-ci-robot · 2020-12-15T11:42:38Z

@afreen23: This pull request references Bugzilla bug 1897830, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

afreen23 · 2020-12-15T11:45:07Z

/test analyze

cloudbehl

Just wanted to understand why we are doing this at first?

cloudbehl · 2020-12-15T11:47:39Z

frontend/packages/ceph-storage-plugin/src/utils/install.ts

-      res.add(nodeName);
-    }
+    const matchExpressions: MatchExpression[] =
+      pv?.spec?.nodeAffinity?.required?.nodeSelectorTerms?.[0]?.matchExpressions;


what if there are multiple node selectors? I think that was the reason we relied on PV label.

For LSO PVs, it will always have hostname based selector.
I confirmed with LSO team on that.

Relying on node affinity is more reliable over label selector. The node affinity field is a mandatory one for PV and will always be present on every PV unlike labels - added as per convenience.
Thats why we had issues in supporting 4.5 OCS on OCP 4.6 where users were trying to create storage cluster via local volume CR and they are blocked, since the pVs created via local volume are not labeled by hostname

The PV's not labeled shouldn't it be fixed in LSO operator? They should provide consistency when the PV is created and have label set.

cloudbehl · 2020-12-15T11:57:53Z

frontend/packages/ceph-storage-plugin/src/utils/install.ts

@@ -48,10 +52,13 @@ export const getTotalDeviceCapacity = (list: Discoveries[]): number =>

 export const getAssociatedNodes = (pvs: K8sResourceKind[]): string[] => {
  const nodes = pvs.reduce((res, pv) => {
-    const nodeName = pv?.metadata?.labels?.[HOSTNAME_LABEL_KEY];


can you tell in which case the HOSTNAME_LABEL_KEY will not be present if =done from localVolumeSet?

There is not any case for local volume set.
The bug is for local volume fix and an improvement over the current implementation where we identify nodes via labels.
See https://github.com/openshift/console/pull/7552/files#r543672246

openshift-ci-robot · 2020-12-16T07:57:44Z

@afreen23: This pull request references Bugzilla bug 1897830, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1897830: Fix cluster creation when using localvolume

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-12-16T07:58:24Z

@afreen23: This pull request references Bugzilla bug 1897830, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1897830: Fix cluster creation when using localvolume

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cloudbehl · 2020-12-16T08:46:29Z

/lgtm

cloudbehl · 2020-12-16T08:46:45Z

/test e2e-gcp-console

openshift-ci-robot · 2020-12-16T08:49:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, cloudbehl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/ceph-storage-plugin/OWNERS~~ [afreen23,cloudbehl]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-12-16T12:43:56Z

@afreen23: All pull requests linked via external trackers have merged:

openshift/console#7552

Bugzilla bug 1897830 has been moved to the MODIFIED state.

In response to this:

Bug 1897830: Fix cluster creation when using localvolume

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

afreen23 · 2020-12-17T13:53:31Z

/cherrypick release-4.6

openshift-cherrypick-robot · 2020-12-17T13:53:45Z

@afreen23: #7552 failed to apply on top of branch "release-4.6":

Applying: Bug 1897830: Fix cluster creation when using localvolume - use the nodeSelector field to get the associated nodes for a PV - drops the usage of labels
Using index info to reconstruct a base tree...
M	frontend/packages/ceph-storage-plugin/src/utils/install.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/ceph-storage-plugin/src/utils/install.ts
CONFLICT (content): Merge conflict in frontend/packages/ceph-storage-plugin/src/utils/install.ts
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bug 1897830: Fix cluster creation when using localvolume - use the nodeSelector field to get the associated nodes for a PV - drops the usage of labels
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Bug 1897830: Fix cluster creation when using localvolume

1a73e76

- use the nodeSelector field to get the associated nodes for a PV - drops the usage of labels Signed-off-by: Afreen Rahman <afrahman@redhat.com>

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 15, 2020

openshift-ci-robot added the component/ceph Related to ceph-storage-plugin label Dec 15, 2020

openshift-ci-robot requested review from a2batic and shyRozen December 15, 2020 11:23

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 15, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 15, 2020

cloudbehl reviewed Dec 15, 2020

View reviewed changes

openshift-ci-robot assigned cloudbehl Dec 16, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2020

openshift-merge-robot merged commit 2efa276 into openshift:master Dec 16, 2020

afreen23 mentioned this pull request Dec 17, 2020

[release-4.6 ]Bug 1908749: Fix cluster creation when using localvolume #7591

Merged

spadgett added this to the v4.7 milestone Jan 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1897830: Fix cluster creation when using localvolume #7552

Bug 1897830: Fix cluster creation when using localvolume #7552

afreen23 commented Dec 15, 2020 •

edited

openshift-ci-robot commented Dec 15, 2020

afreen23 commented Dec 15, 2020

openshift-ci-robot commented Dec 15, 2020

afreen23 commented Dec 15, 2020

cloudbehl left a comment

cloudbehl Dec 15, 2020

afreen23 Dec 15, 2020

afreen23 Dec 15, 2020

cloudbehl Dec 16, 2020

cloudbehl Dec 15, 2020

afreen23 Dec 15, 2020

openshift-ci-robot commented Dec 16, 2020

openshift-ci-robot commented Dec 16, 2020

cloudbehl commented Dec 16, 2020

cloudbehl commented Dec 16, 2020

openshift-ci-robot commented Dec 16, 2020

openshift-ci-robot commented Dec 16, 2020

afreen23 commented Dec 17, 2020

openshift-cherrypick-robot commented Dec 17, 2020

Bug 1897830: Fix cluster creation when using localvolume #7552

Bug 1897830: Fix cluster creation when using localvolume #7552

Conversation

afreen23 commented Dec 15, 2020 • edited

openshift-ci-robot commented Dec 15, 2020

afreen23 commented Dec 15, 2020

openshift-ci-robot commented Dec 15, 2020

afreen23 commented Dec 15, 2020

cloudbehl left a comment

Choose a reason for hiding this comment

cloudbehl Dec 15, 2020

Choose a reason for hiding this comment

afreen23 Dec 15, 2020

Choose a reason for hiding this comment

afreen23 Dec 15, 2020

Choose a reason for hiding this comment

cloudbehl Dec 16, 2020

Choose a reason for hiding this comment

cloudbehl Dec 15, 2020

Choose a reason for hiding this comment

afreen23 Dec 15, 2020

Choose a reason for hiding this comment

openshift-ci-robot commented Dec 16, 2020

openshift-ci-robot commented Dec 16, 2020

cloudbehl commented Dec 16, 2020

cloudbehl commented Dec 16, 2020

openshift-ci-robot commented Dec 16, 2020

openshift-ci-robot commented Dec 16, 2020

afreen23 commented Dec 17, 2020

openshift-cherrypick-robot commented Dec 17, 2020

afreen23 commented Dec 15, 2020 •

edited