-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1907896: Update PF React Topology for new item placement issue #7557
Bug 1907896: Update PF React Topology for new item placement issue #7557
Conversation
@jeff-phillips-18: This pull request references Bugzilla bug 1907896, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
PF React Topology Fix: patternfly/patternfly-react#5249 |
/test analyze |
2 similar comments
/test analyze |
/test analyze |
d856956
to
05f5087
Compare
@jeff-phillips-18: This pull request references Bugzilla bug 1907896, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test analyze |
4 similar comments
/test analyze |
/test analyze |
/test analyze |
/test analyze |
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@jeff-phillips-18: All pull requests linked via external trackers have merged: Bugzilla bug 1907896 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-5256
https://issues.redhat.com/browse/ODC-4988
Analysis / Root cause:
Patternfly React Topology was not running any simulation on an add node so the node was simply centered on the graph without any adjustments for existing nodes.
Patternfly React's Topology ContextMenu was allowing submenus to overflow the viewport and cause a scroll bar to appear.
Solution Description:
Update the version of PF React Topology to get a fix for this issue which runs one round of simulation after adding nodes to make slight adjustments to placement without totally overwriting user node placement. Also pick up a fix to the context menu that uses the viewport rather than the window to determine placement for context menus.
Browser conformance:
/kind bug