New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1908135: move quick search modal inside topology container #7560
Bug 1908135: move quick search modal inside topology container #7560
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome! lgtm!
@christianvogt: This pull request references Bugzilla bug 1908135, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bgliwa01, christianvogt, divyanshiGupta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@christianvogt: All pull requests linked via external trackers have merged: Bugzilla bug 1908135 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-5200
Analysis / Root cause:
Quick search should appear centered over topology without a backdrop.
Solution Description:
Parent the PF modal to the topology container.
Remove the PF modal backdrop using CSS.
Fixed a safari bug which prevented topology from loading.
Screen shots / Gifs for design review:
@bgliwa01
Browser conformance:
cc @rohitkrai03 @divyanshiGupta