Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSOLE 2505: Check in Sprint 193 translations #7578

Merged
merged 1 commit into from Jan 6, 2021
Merged

CONSOLE 2505: Check in Sprint 193 translations #7578

merged 1 commit into from Jan 6, 2021

Conversation

rebeccaalpert
Copy link
Contributor

@rebeccaalpert rebeccaalpert commented Dec 16, 2020 •
edited

Checking in Japanese and Chinese translations for text added or updated in Sprint 193.

Addresses https://issues.redhat.com/browse/CONSOLE-2505.

@openshift-ci-robot openshift-ci-robot added component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dev-console Related to dev-console component/git-service Related to git-service labels Dec 16, 2020
@openshift-ci-robot openshift-ci-robot added component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/lso Related to local-storage-operator-plugin component/metal3 Related to metal3-plugin component/network-attachment-definition Related to network-attachment-definition component/noobaa Related to noobaa-storage-plugin component/olm Related to OLM component/shared Related to console-shared labels Dec 16, 2020
@rebeccaalpert
Copy link
Contributor Author

rebeccaalpert commented Dec 16, 2020 •
edited

CC @rh-tchuang @spadgett

@openshift openshift deleted a comment from rebeccaalpert Dec 16, 2020
@openshift openshift deleted a comment from rebeccaalpert Dec 16, 2020
@openshift openshift deleted a comment from rebeccaalpert Dec 16, 2020
@rhamilto
Copy link
Member

/lgtm cancel

Please squash

@openshift-ci-robot openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2020
@rebeccaalpert
Copy link
Contributor Author

Squashed. Frontend tests seems to be passing now, which is an improvement.

@rhamilto
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 21, 2020
@yapei
Copy link
Contributor

yapei commented Dec 22, 2020

/label qe-approved

@openshift-ci-robot openshift-ci-robot added the qe-approved Signifies that QE has signed off on this PR label Dec 22, 2020
@rebeccaalpert
CONSOLE 2505: Check in Sprint 193 translations
d8f64de 
Checking in Japanese and Chinese translations for text added in Sprint 193.

Fixes https://issues.redhat.com/browse/CONSOLE-2505
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2020
@rebeccaalpert
Copy link
Contributor Author

Rebased.

@spadgett
Copy link
Member

spadgett commented Jan 4, 2021

/retest

@reestr
Copy link

reestr commented Jan 6, 2021

/label px-approved

@openshift-ci-robot openshift-ci-robot added the px-approved Signifies that Product Support has signed off on this PR label Jan 6, 2021
@rhamilto
Copy link
Member

rhamilto commented Jan 6, 2021

/lgtm

/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebeccaalpert, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhamilto
Copy link
Member

rhamilto commented Jan 6, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2021
@openshift-ci-robot
Copy link
Contributor

@spadgett: Overrode contexts on behalf of spadgett: ci/prow/kubevirt-plugin

In response to this:

/override ci/prow/kubevirt-plugin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett
Copy link
Member

spadgett commented Jan 6, 2021

/test ci/prow/kubevirt-plugin

@openshift-ci-robot
Copy link
Contributor

@spadgett: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test analyze
  • /test backend
  • /test e2e-gcp-console
  • /test frontend
  • /test images
  • /test kubevirt-plugin

Use /test all to run all jobs.

In response to this:

/test ci/prow/kubevirt-plugin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett
Copy link
Member

spadgett commented Jan 6, 2021

/test kubevirt-plugin

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 6, 2021

@rebeccaalpert: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/kubevirt-plugin d8f64de link /test kubevirt-plugin

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@spadgett
Copy link
Member

spadgett commented Jan 6, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit ea94f08 into openshift:master Jan 6, 2021
@spadgett spadgett added this to the v4.7 milestone Jan 7, 2021
@spadgett spadgett added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sg00dwin sg00dwin sg00dwin left review comments

@asasabris asasabris asasabris left review comments

@rh-tchuang rh-tchuang rh-tchuang left review comments

@rh-tfu rh-tfu rh-tfu left review comments

@a2batic a2batic Awaiting requested review from a2batic

@afreen23 afreen23 Awaiting requested review from afreen23

Assignees

@rhamilto rhamilto

@sferich888 sferich888

@yapei yapei

@ahardin-rh ahardin-rh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dev-console Related to dev-console component/git-service Related to git-service component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/lso Related to local-storage-operator-plugin component/metal3 Related to metal3-plugin component/network-attachment-definition Related to network-attachment-definition component/noobaa Related to noobaa-storage-plugin component/olm Related to OLM component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet