Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1909207: Fix accessibility issues on monitoring page #7603

Merged
merged 1 commit into from Jan 7, 2021
Merged

Bug 1909207: Fix accessibility issues on monitoring page #7603

merged 1 commit into from Jan 7, 2021

Conversation

jeff-phillips-18
Copy link
Member

Fixes:
https://issues.redhat.com/browse/ODC-5206

Analysis / Root cause:
Dropdowns do not have aria-labels or labels set for them

Solution Description:
Add aria-label to ResourceDropdown, add htmlFor to labels for options dropdowns.

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

/kind bug

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. labels Dec 18, 2020
@openshift-ci-robot
Copy link
Contributor

@jeff-phillips-18: This pull request references Bugzilla bug 1909207, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1909207: Fix accessibility issues on monitoring page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality labels Dec 18, 2020
@openshift-ci-robot openshift-ci-robot added component/dev-console Related to dev-console component/monitoring Related to monitoring component/shared Related to console-shared labels Dec 18, 2020
dtaylor113
dtaylor113 approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@dtaylor113 dtaylor113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2020
@jeff-phillips-18
Copy link
Member Author

/test kubevirt-plugin

2 similar comments
@jeff-phillips-18
Copy link
Member Author

/test kubevirt-plugin

@jeff-phillips-18
Copy link
Member Author

/test kubevirt-plugin

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2021

@jeff-phillips-18: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/kubevirt-plugin 1ed2197 link /test kubevirt-plugin

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2021
@dtaylor113 dtaylor113 self-requested a review January 6, 2021 18:53
dtaylor113
dtaylor113 approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@dtaylor113 dtaylor113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2021
rohitkrai03
rohitkrai03 approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, jeff-phillips-18, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2021
@openshift-merge-robot openshift-merge-robot merged commit 6959b34 into openshift:master Jan 7, 2021
@openshift-ci-robot
Copy link
Contributor

@jeff-phillips-18: All pull requests linked via external trackers have merged:

Bugzilla bug 1909207 has been moved to the MODIFIED state.

In response to this:

Bug 1909207: Fix accessibility issues on monitoring page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitkrai03 rohitkrai03 rohitkrai03 approved these changes

@dtaylor113 dtaylor113 dtaylor113 approved these changes

@jerolimov jerolimov Awaiting requested review from jerolimov

Assignees

@dtaylor113 dtaylor113

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/dev-console Related to dev-console component/monitoring Related to monitoring component/shared Related to console-shared kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jeff-phillips-18 @openshift-ci-robot @rohitkrai03 @dtaylor113 @spadgett @openshift-merge-robot