Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1915929: CONSOLE-2503: Cypress bump to version 6 #7604

Merged
merged 1 commit into from Jan 22, 2021
Merged

Bug 1915929: CONSOLE-2503: Cypress bump to version 6 #7604

merged 1 commit into from Jan 22, 2021

Conversation

dtaylor113
Copy link
Contributor

@dtaylor113 dtaylor113 commented Dec 18, 2020 •
edited by openshift-ci-robot

This PR:

CONSOLE-2503

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. component/core Related to console core functionality labels Dec 18, 2020
@openshift-ci-robot openshift-ci-robot added component/dashboard Related to dashboard component/dev-console Related to dev-console component/olm Related to OLM component/shared Related to console-shared labels Dec 18, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 4, 2021
@spadgett spadgett changed the title [WIP] Cypress bump to version 6 [WIP] CONSOLE-2503: Cypress bump to version 6 Jan 4, 2021
@dtaylor113 dtaylor113 force-pushed the cypress-bump-to-version-6 branch 3 times, most recently from aa589db to 71a6def Compare January 6, 2021 21:13
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2021
@openshift-ci-robot openshift-ci-robot added component/monitoring Related to monitoring and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 6, 2021
@openshift openshift deleted a comment from openshift-ci bot Jan 7, 2021
@dtaylor113 dtaylor113 changed the title [WIP] CONSOLE-2503: Cypress bump to version 6 CONSOLE-2503: Cypress bump to version 6 Jan 11, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 11, 2021
@dtaylor113
Copy link
Contributor Author

Removing WIP label as PR has passed CI 3+ times

@spadgett spadgett added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label Jan 12, 2021
spadgett
spadgett reviewed Jan 12, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dtaylor113

frontend/packages/integration-tests-cypress/support/a11y.ts Outdated Show resolved Hide resolved
frontend/packages/integration-tests-cypress/tests/crud/k8-openshift-cruds.spec.ts Outdated
@@ -97,6 +97,9 @@ describe('Kubernetes resource CRUD operations', () => {

testObjs.forEach(
({ kind, namespaced = true, humanizeKind = true, testI18n = true }, resource) => {
if (Cypress.env('k8TestResource') && kind !== Cypress.env('k8TestResource')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this env var for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debugging, so only one resource is run of the 28. It was helpful being able to only run one of the crud tests when re-running the entire e2e suite for testing this update.

frontend/public/components/monitoring/alerting.tsx Outdated
@@ -394,7 +394,9 @@ const Graph: React.FC<GraphProps> = ({

const GraphLink = () =>
query ? (
<Link to={queryBrowserURL(query, namespace)}>{t('monitoring~View in Metrics')}</Link>
<Link aria-label="link to View in Metrics" to={queryBrowserURL(query, namespace)}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aria-label should be translated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

frontend/packages/topology/src/components/page/TopologyPageToolbar.tsx Outdated Show resolved Hide resolved
frontend/public/components/monitoring/query-browser.tsx Outdated Show resolved Hide resolved
test-remote-cluster.sh Outdated Show resolved Hide resolved
frontend/packages/console-shared/src/components/dashboard/utilization-card/UtilizationBody.tsx Outdated
@@ -17,6 +17,7 @@ const UtilizationAxis: React.FC<UtilizationAxisProps> = ({ timestamps = [] }) =>
<div ref={containerRef}>
{!!timestamps.length && (
<ChartAxis
containerComponent={<ChartContainer title="time axis" />}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be translated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is changing more than test code, we need to have QE review. A Bugzilla bug would be good since it has accessible fixes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created Bug 1915929 - A11y Violation: svg-img-alt for time axis of Utilization Card on Cluster Dashboard

@dtaylor113 dtaylor113 force-pushed the cypress-bump-to-version-6 branch 2 times, most recently from 7613e22 to 7ba4714 Compare January 12, 2021 15:24
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

16 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

/lgtm cancel

@dtaylor113 You need to run prettier :/

@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 21, 2021
spadgett
spadgett approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 1294f03 into openshift:master Jan 22, 2021
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 22, 2021 •
edited

@dtaylor113: All pull requests linked via external trackers have merged:

Bugzilla bug 1915929 has been moved to the MODIFIED state.

In response to this:

Bug 1915929: CONSOLE-2503: Cypress bump to version 6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@jhadvig jhadvig Awaiting requested review from jhadvig

@andybraren andybraren Awaiting requested review from andybraren

@rottencandy rottencandy Awaiting requested review from rottencandy

Assignees

@rhamilto rhamilto

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/monitoring Related to monitoring component/olm Related to OLM component/shared Related to console-shared kind/dependency-change Categorizes issue or PR as related to changing dependencies kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dtaylor113 @openshift-ci-robot @spadgett @openshift-bot @rhamilto @openshift-merge-robot