Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1909958: Add QuickStart highlight labels #7625

Merged
merged 1 commit into from Jan 6, 2021
Merged

Bug 1909958: Add QuickStart highlight labels #7625

merged 1 commit into from Jan 6, 2021

Conversation

rottencandy
Copy link
Contributor

Fixes:
https://issues.redhat.com/browse/ODC-5201

Analysis / Root cause:
The quick starts highlight does not support all places, and uses the guided tour ids.

Solution Description:
Add the data attribute data-quickstart-id to elements to be supported, and create labels for the following labels for supported items:

Admin Navbar Items:
  • qs-nav-home
  • qs-nav-operators
  • qs-nav-workloads
  • qs-nav-builds
  • qs-nav-serverless
  • qs-nav-pipelines
  • qs-nav-monitoring
  • qs-nav-networking
  • qs-nav-storage
  • qs-nav-servicecatalog
  • qs-nav-compute
  • qs-nav-usermanagement
  • qs-nav-administration
Developer Navbar Items:
  • qs-nav-add
  • qs-nav-topology
  • qs-nav-search
  • qs-nav-project
  • qs-nav-pipelines
  • qs-nav-helm
Masthead Items:
  • qs-masthead-cloudshell
  • qs-masthead-utilitymenu
  • qs-masthead-usermenu
  • qs-masthead-applications
  • qs-nav-import
  • qs-masthead-help
  • qs-masthead-notifications

Unit test coverage report:
Unchanged.

Test setup:
Example quick start:

apiVersion: console.openshift.io/v1
kind: ConsoleQuickStart
metadata:
  name: test-highlights
spec:
  description: Description here
  displayName: test highlights
  durationMinutes: 1
  introduction: Introduction here
  tasks:
    - description: |
        Perspective switcher: [link]{{highlight qs-perspective-switcher}}

        ### Admin perspective nav Links:
        - [Home]{{highlight qs-nav-home}}
        - [Operators]{{highlight qs-nav-operators}}
        - [Workloads]{{highlight qs-nav-workloads}}
        - [Serverless]{{highlight qs-nav-serverless}}
        - [Networking]{{highlight qs-nav-networking}}
        - [Storage]{{highlight qs-nav-storage}}
        - [Service catalog]{{highlight qs-nav-servicecatalog}}
        - [Compute]{{highlight qs-nav-compute}}
        - [User maganement]{{highlight qs-nav-usermanagement}}
        - [Administration]{{highlight qs-nav-administration}}

        ### Dev perspective nav Links:
        - [Add]{{highlight qs-nav-add}}
        - [Topology]{{highlight qs-nav-topology}}
        - [Search]{{highlight qs-nav-search}}
        - [Project]{{highlight qs-nav-project}}
        - [Helm]{{highlight qs-nav-helm}}

        ### Common nav Links:
        - [Builds]{{highlight qs-nav-builds}}
        - [Pipelines]{{highlight qs-nav-pipelines}}
        - [Monitoring]{{highlight qs-nav-monitoring}}

        ### Masthead Links:
        - [CloudShell]{{highlight qs-masthead-cloudshell}}
        - [Utility Menu]{{highlight qs-masthead-utilitymenu}}
        - [User Menu]{{highlight qs-masthead-usermenu}}
        - [Applications]{{highlight qs-masthead-applications}}
        - [Import]{{highlight qs-masthead-import}}
        - [Help]{{highlight qs-masthead-help}}
        - [Notifications]{{highlight qs-masthead-notifications}}
      title: test highlight

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@rottencandy
add quick start highlight labels
e4514fd 
Adds quick start highlight ids and labels for the following elements:

- Admin nav items
- Developer nav items
- Masthead buttons
@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Dec 22, 2020
@openshift-ci-robot openshift-ci-robot added component/dev-console Related to dev-console component/sdk Related to console-plugin-sdk component/shared Related to console-shared labels Dec 22, 2020
@rottencandy
Copy link
Contributor Author

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 22, 2020
@rottencandy rottencandy changed the title Add QuickStart highlight labels Bug 1909958: Add QuickStart highlight labels Dec 22, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 22, 2020
@openshift-ci-robot
Copy link
Contributor

@rottencandy: This pull request references Bugzilla bug 1909958, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1909958: Add QuickStart highlight labels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rottencandy
Copy link
Contributor Author

/cc @andrewballantyne

@nemesis09
Copy link
Contributor

/retest

@nemesis09
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2021
@rohitkrai03
Copy link
Contributor

/assign

@rottencandy
Copy link
Contributor Author

/retest

rohitkrai03
rohitkrai03 approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nemesis09, rohitkrai03, rottencandy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2021
@rohitkrai03
Copy link
Contributor

/retest

1 similar comment
@rottencandy
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 6, 2021

@rottencandy: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/kubevirt-plugin e4514fd link /test kubevirt-plugin

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f5834cc into openshift:master Jan 6, 2021
@openshift-ci-robot
Copy link
Contributor

@rottencandy: All pull requests linked via external trackers have merged:

Bugzilla bug 1909958 has been moved to the MODIFIED state.

In response to this:

Bug 1909958: Add QuickStart highlight labels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Jan 7, 2021
@rottencandy rottencandy deleted the qshighlight branch February 8, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitkrai03 rohitkrai03 rohitkrai03 approved these changes

@nemesis09 nemesis09 Awaiting requested review from nemesis09

@sahil143 sahil143 Awaiting requested review from sahil143

@andrewballantyne andrewballantyne Awaiting requested review from andrewballantyne

Assignees

@rohitkrai03 rohitkrai03

@nemesis09 nemesis09

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/dev-console Related to dev-console component/sdk Related to console-plugin-sdk component/shared Related to console-shared kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rottencandy @openshift-ci-robot @nemesis09 @rohitkrai03 @openshift-bot @spadgett @openshift-merge-robot