Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1910263: Adjust wizard to make existing tests to be able to run #7627

Merged
merged 1 commit into from Dec 24, 2020
Merged

Bug 1910263: Adjust wizard to make existing tests to be able to run #7627

merged 1 commit into from Dec 24, 2020

Conversation

gouyang
Copy link
Contributor

@gouyang gouyang commented Dec 22, 2020

This is only focus on make the existing tests to be able to run, the simple flow is not covered.

@openshift-ci-robot openshift-ci-robot added the component/kubevirt Related to kubevirt-plugin label Dec 22, 2020
@gouyang
Copy link
Contributor Author

gouyang commented Dec 23, 2020

/test analyze

@gouyang gouyang changed the title Adjust wizard to make existing tests to be able to run Bug 1910263: Adjust wizard to make existing tests to be able to run Dec 23, 2020
@openshift-ci-robot
Copy link
Contributor

@gouyang: This pull request references Bugzilla bug 1910263, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1910263: Adjust wizard to make existing tests to be able to run

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 23, 2020
@gouyang
Copy link
Contributor Author

gouyang commented Dec 23, 2020

/test kubevirt-plugin

@yaacov
Copy link
Member

yaacov commented Dec 23, 2020

@gouyang hi, kubevirt-plugin CI is currently broken (openshift/kubernetes#496), to pass it you need to push into the PR so the robot will catch a new change, and will remove the broken CI from the list of tests.

@gouyang
Copy link
Contributor Author

gouyang commented Dec 23, 2020

@yaacov Thanks, pushed again.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 23, 2020 •
edited

@gouyang: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/kubevirt-plugin 2a2d79c link /test kubevirt-plugin

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gouyang
Copy link
Contributor Author

gouyang commented Dec 24, 2020

/test analyze

@gouyang
Copy link
Contributor Author

gouyang commented Dec 24, 2020

@yaacov Looks kubevirt-plugin tests is not here anymore. Could you or ask someone review the PR, I don't know who are available during the Holiday.

@yaacov
Copy link
Member

yaacov commented Dec 24, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 24, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gouyang, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 24, 2020
@openshift-merge-robot openshift-merge-robot merged commit d86f766 into openshift:master Dec 24, 2020
@openshift-ci-robot
Copy link
Contributor

@gouyang: All pull requests linked via external trackers have merged:

Bugzilla bug 1910263 has been moved to the MODIFIED state.

In response to this:

Bug 1910263: Adjust wizard to make existing tests to be able to run

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irosenzw irosenzw Awaiting requested review from irosenzw

@vojtechszocs vojtechszocs Awaiting requested review from vojtechszocs

Assignees

@yaacov yaacov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gouyang @openshift-ci-robot @yaacov @spadgett @openshift-merge-robot