Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.6] Bug 1910156: Add tolerations for ocs taint in localvolumeset and localvolumediscovery #7636

Merged
merged 1 commit into from Jan 8, 2021
Merged

[release-4.6] Bug 1910156: Add tolerations for ocs taint in localvolumeset and localvolumediscovery #7636

merged 1 commit into from Jan 8, 2021

Conversation

afreen23
Copy link
Contributor

@afreen23 afreen23 commented Dec 22, 2020 •
edited

  • handles displaying nodes, tainted with the taint "node.ocs.openshift.io/storage="true":NoSchedule"
  • by default seeting tolerations for ocs-taints in lvset and lvd yamls in OCS UI

Signed-off-by: Afreen Rahman afrahman@redhat.com
(cherry picked from commit 9da4921)

Automated cherrypick failed

Bug 1910156: Add tolerations for ocs taint node.ocs.openshift.io/stor…
a389c2f 
…age="true":NoSchedule in localvolumeset and localvolumediscovery

- handles displaying nodes, tainted with the taint "node.ocs.openshift.io/storage="true":NoSchedule"
- by default seeting tolerations for ocs-taints in lvset and lvd yamls in OCS UI

Signed-off-by: Afreen Rahman <afrahman@redhat.com>
(cherry picked from commit 9da4921)

	frontend/packages/ceph-storage-plugin/src/components/ocs-install/attached-devices/create-sc/create-sc.tsx
	frontend/packages/ceph-storage-plugin/src/components/ocs-install/attached-devices/create-sc/wizard-pages/auto-detect-volume.tsx
	frontend/packages/ceph-storage-plugin/src/components/ocs-install/attached-devices/create-sc/wizard-pages/create-local-volume-set.tsx
	frontend/packages/ceph-storage-plugin/src/constants/ocs-install.ts
	frontend/packages/local-storage-operator-plugin/src/components/auto-detect-volume/auto-detect-volume-inner.tsx
	frontend/packages/local-storage-operator-plugin/src/components/local-volume-set/local-volume-set-inner.tsx
	frontend/packages/local-storage-operator-plugin/src/components/local-volume-set/nodes-selection-list.tsx
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 22, 2020
@openshift-ci-robot
Copy link
Contributor

@afreen23: This pull request references Bugzilla bug 1910156, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1903255 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1903255 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents

In response to this:

Bug 1910156: Add tolerations for ocs taint node.ocs.openshift.io/storage="true":NoSchedule in localvolumeset and localvolumediscovery

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added component/ceph Related to ceph-storage-plugin component/lso Related to local-storage-operator-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 22, 2020
@openshift-ci-robot
Copy link
Contributor

@afreen23: This pull request references Bugzilla bug 1910156, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1903255 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1903255 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents

In response to this:

Bug 1910156: Add tolerations for ocs taint node.ocs.openshift.io/storage="true":NoSchedule in localvolumeset and localvolumediscovery

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afreen23 afreen23 changed the title Bug 1910156: Add tolerations for ocs taint node.ocs.openshift.io/storage="true":NoSchedule in localvolumeset and localvolumediscovery Bug 1910156: Add tolerations for ocs taint in localvolumeset and localvolumediscovery Dec 22, 2020
@afreen23 afreen23 changed the title Bug 1910156: Add tolerations for ocs taint in localvolumeset and localvolumediscovery [release-4.6] Bug 1910156: Add tolerations for ocs taint in localvolumeset and localvolumediscovery Dec 23, 2020
@cloudbehl
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, cloudbehl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@russellb russellb added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Jan 6, 2021
@openshift-merge-robot openshift-merge-robot merged commit a9f1f8c into openshift:release-4.6 Jan 8, 2021
@openshift-ci-robot
Copy link
Contributor

@afreen23: All pull requests linked via external trackers have merged:

Bugzilla bug 1910156 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1910156: Add tolerations for ocs taint in localvolumeset and localvolumediscovery

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6.z milestone Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a2batic a2batic Awaiting requested review from a2batic

@cloudbehl cloudbehl Awaiting requested review from cloudbehl

Assignees

@cloudbehl cloudbehl

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/ceph Related to ceph-storage-plugin component/lso Related to local-storage-operator-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6.z
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@afreen23 @openshift-ci-robot @cloudbehl @russellb @spadgett @openshift-merge-robot