Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1909821: Fix flexible scaling enablement #7643

Merged
merged 1 commit into from Dec 24, 2020
Merged

Bug 1909821: Fix flexible scaling enablement #7643

merged 1 commit into from Dec 24, 2020

Conversation

afreen23
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Dec 23, 2020
@openshift-ci-robot
Copy link
Contributor

@afreen23: This pull request references Bugzilla bug 1909821, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1909821: Fix flexible scaling enablement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/ceph Related to ceph-storage-plugin labels Dec 23, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2020
@afreen23 afreen23 force-pushed the master branch 3 times, most recently from f1bf7ae to 65f2c59 Compare December 23, 2020 14:06
cloudbehl
cloudbehl reviewed Dec 23, 2020
View reviewed changes
...rc/components/ocs-install/attached-devices/create-sc/wizard-pages/storage-and-nodes-step.tsx Outdated
@@ -109,9 +107,9 @@ export const StorageAndNodes: React.FC<StorageAndNodesProps> = ({ state, dispatc
}, [cpu, dispatch, memory, nodesCount]);

React.useEffect(() => {
const isFlexibleScaling: boolean = scNodeNamesLength && zonesCount < 3;
const isFlexibleScaling: boolean = !!(nodesCount >= MINIMUM_NODES && zonesCount < 3);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed one more thing.

if arbiter is enabled the nodesCount is 3 and zones is 2, flexible sizing will get in place which should not happen. we need to check for if arbiter is enabled then flexible should not be enabled.

Also if you can move this logic to a single place so we don't need to change both always.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay arbiter is not for internal mode, so we can instead guard on arbiter itself.
We should not mix two diff logics. flexible scaling should stay intact.
I will make that change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for flexible scaling, we have single logic for internal & internal-attached.
attachedDevices
!!(nodesCount >= MINIMUM_NODES && zonesCount < 3)
internal
!!(nodesCount >= MINIMUM_NODES && zonesCount < 3)

we can place them somewhere in utils so we don't miss out other if there is a change in one.

Copy link
Contributor Author

@afreen23 afreen23 Dec 23, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I assumed the ask was for arbiter.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @afreen23 looks much better now. :)

@cloudbehl
Copy link
Contributor

/lgtm
/test analyze

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, cloudbehl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cloudbehl
Copy link
Contributor

/test analyze

1 similar comment
@cloudbehl
Copy link
Contributor

/test analyze

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b4d01d7 into openshift:master Dec 24, 2020
@openshift-ci-robot
Copy link
Contributor

@afreen23: All pull requests linked via external trackers have merged:

Bugzilla bug 1909821 has been moved to the MODIFIED state.

In response to this:

Bug 1909821: Fix flexible scaling enablement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudbehl cloudbehl cloudbehl left review comments

@shyRozen shyRozen Awaiting requested review from shyRozen

Assignees

@cloudbehl cloudbehl

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/ceph Related to ceph-storage-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@afreen23 @openshift-ci-robot @cloudbehl @openshift-bot @spadgett @openshift-merge-robot