New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1907989: Added support for dataVolumeTemplate in yaml #7645
Bug 1907989: Added support for dataVolumeTemplate in yaml #7645
Conversation
@metalice: This pull request references Bugzilla bug 1907989, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 comment
disk: { | ||
bus: | ||
vmWrapper.getDisks().find((d) => { | ||
return ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return ( | |
const dv = vmWrapper | |
.getDataVolumeTemplates() | |
.find( | |
(dataVolumeTemplate) => | |
dataVolumeTemplate?.spec?.source?.pvc?.name === nameParam, | |
) | |
return d.name === dv?.metadata?.name |
...nd/packages/kubevirt-plugin/src/components/create-vm-wizard/tabs/storage-tab/storage-tab.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/kubevirt-plugin/src/k8s/requests/vm/create/simple-create.ts
Outdated
Show resolved
Hide resolved
frontend/packages/kubevirt-plugin/src/k8s/wrapper/vm/vm-wrapper.ts
Outdated
Show resolved
Hide resolved
frontend/packages/kubevirt-plugin/src/k8s/wrapper/vm/vm-wrapper.ts
Outdated
Show resolved
Hide resolved
frontend/packages/kubevirt-plugin/src/selectors/immutable/template/combined.ts
Outdated
Show resolved
Hide resolved
/retest |
frontend/packages/kubevirt-plugin/src/k8s/requests/vm/create/simple-create.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Matan Schatzman <mschatzm@redhat.com> Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
fd57225
to
3ae8432
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalice, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@metalice: All pull requests linked via external trackers have merged: Bugzilla bug 1907989 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Matan Schatzman mschatzm@redhat.com
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1907989
Analysis / Root cause:
DataVolumeTemplate was conflicting with wizard storage.
Solution Description:
Change the behavior of wizards to work with DataVolumeTemplate by ignoring the data provided by the template and using storages created by wizards.