Bug 1910805: add translation for pipeline status #7657
Conversation
vikram-raj
changed the title
openshift-ci-robot
added
bugzilla/severity-medium
|
@vikram-raj: This pull request references Bugzilla bug 1910805, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
these are missed |
|
Added the translation for pipelines create options. |
There was a problem hiding this comment.
@vikram-raj Also with this PR the pipeline status fields are not translated. On the Pipeline list, PipelineRun list as well on the TaskRun list:
In the breadcrumb the word "Pipelines" is not translated on the overview page and on the pipeline detail page. But it is translated in the navigation. We do this also for Build Configs and Helm Release, so I think we should do this also for Pipelines:
|
@jerolimov Added the translation for the |
|
@vikram-raj Isn't it explicitly in your ticket to support the status values? Am I missing something or misunderstanding something?
|
|
@jerolimov @andrewballantyne Added translation for status as well. |
openshift-ci-robot
added
the
kind/i18n
| <Trans t={t} ns="pipelines-plugin"> | ||
| Use this format when referencing variables in this form:{' '} | ||
| <code>{`$(${paramPrefix}parameter)`}</code> | ||
| </Trans> | ||
| {t('pipelines-plugin~Use this format when referencing variables in this form: ')} | ||
| <code>{`$(${paramPrefix}parameter)`}</code> |
|
/assign @andrewballantyne Andrew, FYI, we discussed that we do not translate the status in the header field at the moment because this needs a unnecessary big refactoring. This field is also not translated for Pods etc. So there are still many small things to-do for 4.7.z or 4.8. Are you fine with this?
|
That's not ideal but can be done separately of this PR. Please open up a forum to discuss with the Admin team in #tmp-i18n slack room. See if they are aware of / already addressing the status in the header. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, jerolimov, vikram-raj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@vikram-raj: All pull requests linked via external trackers have merged: Bugzilla bug 1910805 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-5292
Analysis / Root cause:
Translation for Pipeline status and breadcrumb text is missing.
Solution Description:
Add translation for Pipeline status and breadcrumb text.