Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1890731: Migration status title is now showing state of migration #7664

Merged
merged 1 commit into from Dec 29, 2020
Merged

Bug 1890731: Migration status title is now showing state of migration #7664

merged 1 commit into from Dec 29, 2020

Conversation

metalice
Copy link
Contributor

Signed-off-by: Matan Schatzman mschatzm@redhat.com

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1890731

Analysis / Root cause:
The title wasn't taken from migration status but from machine status.

Solution Description:
The title is now constructed from migration status or machine status.

Screen shots / Gifs for design review:
bug 1890731

@openshift-ci-robot
Copy link
Contributor

@metalice: Bugzilla bug 1890731 is in a bug group that is not in the allowed groups for this repo.
Allowed groups for this repo are:

  • qe_staff
  • redhat

In response to this:

Bug 1890731: Migration status title is now showing state of migration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@glekner
Copy link
Contributor

glekner commented Dec 28, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 28, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@yaacov
Copy link
Member

yaacov commented Dec 28, 2020

/retest

@metalice
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 28, 2020
@metalice metalice force-pushed the bz-1890731-ui-migration-state-queue branch from 576dcb1 to 8ae2401 Compare December 28, 2020 18:10
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 28, 2020
@metalice
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 28, 2020
@metalice metalice force-pushed the bz-1890731-ui-migration-state-queue branch from 8ae2401 to a360de7 Compare December 29, 2020 08:26
@yaacov
Copy link
Member

yaacov commented Dec 29, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 29, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@yaacov
Copy link
Member

yaacov commented Dec 29, 2020

/hold
for translations

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 29, 2020
@metalice
Migration status title is now showing state of migration
fd4acb1 
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
@metalice metalice force-pushed the bz-1890731-ui-migration-state-queue branch from a360de7 to fd4acb1 Compare December 29, 2020 12:26
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 29, 2020
@yaacov
Copy link
Member

yaacov commented Dec 29, 2020

/hold cancel
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 29, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glekner, metalice, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7a898f8 into openshift:master Dec 29, 2020
@spadgett spadgett added this to the v4.7 milestone Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaacov yaacov yaacov left review comments

@glekner glekner glekner requested changes

@gouyang gouyang Awaiting requested review from gouyang

@jelkosz jelkosz Awaiting requested review from jelkosz

Assignees

@yaacov yaacov

@glekner glekner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@metalice @openshift-ci-robot @glekner @openshift-bot @yaacov @spadgett @openshift-merge-robot