Bug 1911474: Delete Devfile Application Group without any errors #7677
Conversation
|
/kind bug |
openshift-ci-robot
added
the
kind/bug
debsmita1
changed the title
openshift-ci-robot
added
bugzilla/severity-medium
|
@debsmita1: This pull request references Bugzilla bug 1911474, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| webhookTypeObj.secretReference?.name ?? | ||
| `${resource.metadata.name}-${webhookType}-webhook-secret`; | ||
| const secretResource = secretList.find((secret) => secret.metadata.name === secretName); | ||
| if (!_.isEmpty(secretResource)) { |
There was a problem hiding this comment.
| if (!_.isEmpty(secretResource)) { | |
| if (secretResource) { |
| namespace: resource.metadata.namespace, | ||
| }, | ||
| }; | ||
| } | ||
| } | ||
| return obj ? [...a, safeKill(SecretModel, obj)] : a; |
There was a problem hiding this comment.
Also since here we are now getting the list of the secrets in the ns and finding if the secret we want to delete exists and then deleting it, why not use secretResource here rather than creating another obj?
debsmita1
force-pushed
the
fix-delete-app-error
branch
from
2fe838e
to
5dc3eda
Compare
|
fixing the failed tc |
debsmita1
force-pushed
the
fix-delete-app-error
branch
from
5dc3eda
to
72e2474
Compare
fixed |
|
/retest |
|
Verified locally, works fine for me. |
|
/test analyze |
|
/assign @rohitkrai03 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: debsmita1, divyanshiGupta, rohitkrai03 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@debsmita1: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@debsmita1: All pull requests linked via external trackers have merged: Bugzilla bug 1911474 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-5298
Analysis / Root cause:
before deleting the webhook secret, it is not being checked if the secret exists.
Solution Description:
listing the available secrets in the namespace, and added a check to verify if the associated secret exists
GIF:
Browser conformance: