Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1911809: [interop-ui-tests] update steps in install helm chart feature file #7680

Merged
merged 2 commits into from Jan 6, 2021
Merged

Bug 1911809: [interop-ui-tests] update steps in install helm chart feature file #7680

merged 2 commits into from Jan 6, 2021

Conversation

shvasude
Copy link
Contributor

@shvasude shvasude commented Dec 30, 2020 •
edited

Jira Id: https://issues.redhat.com/browse/HELM-15, https://issues.redhat.com/browse/HELM-66
Bugzill ID: Bug 1911809
Update steps for scenario:

  • Install Helm Chart from Developer Catalog Page using YAML View: HR-03
  • Install Helm Chart from +Add Page using Form View: HR-02-TC01
  • Chart versions drop down menu

@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Dec 30, 2020
@shvasude
Copy link
Contributor Author

/assign @makambalaji

makambalaji
makambalaji reviewed Dec 30, 2020
View reviewed changes
frontend/packages/dev-console/integration-tests/features/helm/install-HelmChart.feature Outdated
Given user is at developer perspecitve
And user has selected namespace "aut-helm-installation"
Background:
Given user is at developer perspecitve
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Given user is at developer perspecitve
Given user is at developer perspective

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/openshift/console/pull/7656/files address the same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, 9c70186

@shvasude shvasude force-pushed the interop-ui-install-helm-feature branch from f166888 to 9c70186 Compare December 30, 2020 18:59
@makambalaji
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 31, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@makambalaji
Copy link
Contributor

Please add bugzilla number for this pr

@makambalaji
Copy link
Contributor

/approve cancel

@openshift-ci-robot openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 31, 2020
@shvasude
Copy link
Contributor Author

Please add bugzilla number for this pr

Added the JIRA ID

@shvasude shvasude changed the title [interop-ui-tests] update steps in install helm chart feature file Bug 1911809: [interop-ui-tests] update steps in install helm chart feature file Jan 4, 2021
@openshift-ci-robot
Copy link
Contributor

@shvasude: This pull request references Bugzilla bug 1911809, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1911809: [interop-ui-tests] update steps in install helm chart feature file

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 4, 2021
@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: This pull request references Bugzilla bug 1911809, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andrewballantyne
Copy link
Contributor

/bugzilla refresh
/retest

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 5, 2021
@openshift-ci-robot
Copy link
Contributor

@andrewballantyne: This pull request references Bugzilla bug 1911809, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shvasude
Copy link
Contributor Author

shvasude commented Jan 5, 2021

/retest

@makambalaji
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: makambalaji, shvasude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4dc8c7a into openshift:master Jan 6, 2021
@openshift-ci-robot
Copy link
Contributor

@shvasude: All pull requests linked via external trackers have merged:

Bugzilla bug 1911809 has been moved to the MODIFIED state.

In response to this:

Bug 1911809: [interop-ui-tests] update steps in install helm chart feature file

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makambalaji makambalaji makambalaji left review comments

@gajanan-more gajanan-more Awaiting requested review from gajanan-more

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

Assignees

@makambalaji makambalaji

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@shvasude @makambalaji @openshift-bot @openshift-ci-robot @andrewballantyne @spadgett @openshift-merge-robot