New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1910501: Use absolute paths when resource creation is cancelled #7694
Conversation
@bipuladh: This pull request references Bugzilla bug 1910501, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for all
const onCancel = () => { | ||
history.goBack(); | ||
}; | ||
const onCancel = () => history.push(`/k8s/ns/${ns}/clusterserviceversions/${appName}/`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The correct path should be one with thegroupVersionKind
instead of clusterserviceversions
.
Any reason for clusterserviceversions
?
Additionally resourcePathFromModel
would work here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@afreen23 why do you prefer GVK over plural, we use plural all over our plugin declaration file. And we use plural after resource creation in history.push
everywhere. resourcePathFromModel will not redirect to the OLM pages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have observed in console that operator pages are following the:
k8s/ns/openshift-storage/operators.coreos.com~v1alpha1~ClusterServiceVersion/ocs-operator.v4.6.0
And resourcePathFromModel will redirect to the operator page since you have the operator name -> appName and ns.
Something like this:
resourcePathFromModel(ClusterServiceVersionModel, appName, ns)
/test analyze |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afreen23, bipuladh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@bipuladh: All pull requests linked via external trackers have merged: Bugzilla bug 1910501 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.