Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONSOLE-2400: Bump react to v17 #7736

Merged
merged 1 commit into from Apr 7, 2021

Conversation

zherman0
Copy link
Member

@zherman0 zherman0 commented Jan 6, 2021

Bump React from 16.x to 17.0.1 and other dependencies as needed.
CONSOLE-2400

Did not bump types/react to 17 as there were serious conflicts. Still investigating options for that.

@spadgett
Copy link
Member

spadgett commented Jan 6, 2021

@zherman0 Looks like enzyme doesn't support React 17, which is causing the test errors, so we might be blocked. See enzymejs/enzyme#2429

/cc @christianvogt

@zherman0
Copy link
Member Author

zherman0 commented Jan 7, 2021

/hold
We have several dependency issues that have not been resolved by third party modules. We are holding this until 4.8 to give those external modules time to update to React 17.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2021
@spadgett spadgett added this to the v4.8 milestone Jan 7, 2021
@spadgett spadgett added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label Jan 7, 2021
@spadgett
Copy link
Member

/override ci/prow/ceph-storage-plugin

The ceph-storage-plugin job should only have run on PRs with changes to frontend/packages/ceph-storage-plugin. It failed due to an unrelated CI config change. Overriding status on this PR.

@openshift-ci-robot
Copy link
Contributor

@spadgett: Overrode contexts on behalf of spadgett: ci/prow/ceph-storage-plugin

In response to this:

/override ci/prow/ceph-storage-plugin

The ceph-storage-plugin job should only have run on PRs with changes to frontend/packages/ceph-storage-plugin. It failed due to an unrelated CI config change. Overriding status on this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zherman0
Copy link
Member Author

@spadgett - Enzyme still does not support React 17, however yarn add --dev @wojtekmaj/enzyme-adapter-react-17 is suppose to be a viable workaround. Shall I replace the official enzyme with this personal repo and test everything?

@spadgett
Copy link
Member

Yeah, I'm good with adding the adapter to unblock us until enzyme adds support.

@zherman0
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2021
frontend/before-tests.js Outdated Show resolved Hide resolved
frontend/@types/gql/queries.d.ts Outdated Show resolved Hide resolved
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold for approvals
/assign @yapei @ahardin-rh @sferich888

@yapei This simply needs a basic regression test of console. There is no visible change to the UI.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, zherman0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 18, 2021
@ahardin-rh
Copy link

/label docs-approved

@openshift-ci-robot openshift-ci-robot added the docs-approved Signifies that Docs has signed off on this PR label Mar 23, 2021
@yapei
Copy link
Contributor

yapei commented Mar 25, 2021

/label qe-approved

@openshift-ci-robot openshift-ci-robot added the qe-approved Signifies that QE has signed off on this PR label Mar 25, 2021
@sferich888
Copy link

/label px-approved
/unassign @sferich888

@openshift-ci-robot openshift-ci-robot added the px-approved Signifies that Product Support has signed off on this PR label Apr 6, 2021
@spadgett
Copy link
Member

spadgett commented Apr 6, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 6, 2021
@openshift-merge-robot openshift-merge-robot merged commit dfee826 into openshift:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants