New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONSOLE-2400: Bump react to v17 #7736
Conversation
@zherman0 Looks like enzyme doesn't support React 17, which is causing the test errors, so we might be blocked. See enzymejs/enzyme#2429 /cc @christianvogt |
/hold |
/override ci/prow/ceph-storage-plugin The ceph-storage-plugin job should only have run on PRs with changes to |
@spadgett: Overrode contexts on behalf of spadgett: ci/prow/ceph-storage-plugin In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@spadgett - Enzyme still does not support React 17, however yarn add --dev @wojtekmaj/enzyme-adapter-react-17 is suppose to be a viable workaround. Shall I replace the official enzyme with this personal repo and test everything? |
Yeah, I'm good with adding the adapter to unblock us until enzyme adds support. |
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold for approvals
/assign @yapei @ahardin-rh @sferich888
@yapei This simply needs a basic regression test of console. There is no visible change to the UI.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spadgett, zherman0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label docs-approved |
/label qe-approved |
/label px-approved |
/hold cancel |
Bump React from 16.x to 17.0.1 and other dependencies as needed.
CONSOLE-2400
Did not bump types/react to 17 as there were serious conflicts. Still investigating options for that.