New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1909004: make filesystem queries compatible with both RHCOS and RHEL nodes #7739
Conversation
@sjenning: This pull request references Bugzilla bug 1909004, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sjenning: This pull request references Bugzilla bug 1909004, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Verified this still works for a full RHCOS cluster in AWS. Verifying on a RHEL worker next. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold since @sjenning is still testing
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sjenning, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yep, it works on the RHEL worker |
@sjenning: All pull requests linked via external trackers have merged: Bugzilla bug 1909004 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.6 |
@spadgett: new pull request created: #7777 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.5 |
@spadgett: new pull request created: #7796 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
FYI @openshift/openshift-team-monitoring |
This ended up breaking the filesystem graph for Windows nodes 😞 |
@openshift/openshift-team-windows-containers is looking into why and how to prevent such breakages in the future. |
Seems like #7201 is the PR that broke Windows and not this PR. We are looking into adding an e2e test to the console repo or WMCO repo to catch such breakages in the future. |
#7201 fixed filesystem queries for RHCOS nodes but does not work for RHEL nodes.
For RHCOS, both
/
and/var
are bind mounts to the same underlying/sysroot
, which is just a dm-crypt on the 4th GPT disk partition.Thus, using
/
instead of/var
is less precise for RHCOS nodes, but should still provide correct behavior for RHCOS and mostly correct behavior for RHEL nodes. If the RHEL node is using a separate/var
partition, it will not be correct. Right now, however, RHEL nodes show no data at all, which is the bug for which this PR is opened.@spadgett @jhadvig