CONSOLE-2521: Migrate Role Binding CRUD tests to Cypress #7756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccaalpert
added
the
do-not-merge/hold
openshift-ci-robot
added
do-not-merge/work-in-progress
|
@rebeccaalpert I think it's good to break this up into smaller PRs anyway. |
|
/cc @dtaylor113 |
rebeccaalpert
changed the title
rebeccaalpert
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
I'm updating this to reflect that it's a sub-task PR now. |
|
/retest |
1 similar comment
|
/retest |
spadgett
reviewed
Jan 8, 2021
frontend/packages/integration-tests-cypress/tests/crud/rolebindings.spec.ts
Outdated
Show resolved
Hide resolved
dtaylor113
reviewed
Jan 11, 2021
frontend/packages/integration-tests-cypress/tests/crud/rolebindings.spec.ts
Show resolved
Hide resolved
frontend/packages/integration-tests-cypress/views/rolebindings.ts
Outdated
Show resolved
Hide resolved
frontend/packages/integration-tests-cypress/tests/crud/rolebindings.spec.ts
Outdated
Show resolved
Hide resolved
frontend/packages/integration-tests-cypress/tests/crud/rolebindings.spec.ts
Outdated
Show resolved
Hide resolved
frontend/packages/integration-tests-cypress/views/rolebindings.ts
Outdated
Show resolved
Hide resolved
dtaylor113
approved these changes
Jan 11, 2021
rebeccaalpert
force-pushed
the
cypress
branch
from
ed4e999
to
164e9f9
Compare
|
Updated id and removed duplicate test. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtaylor113, rebeccaalpert, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/test e2e-gcp-console |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated Role Binding tests and removed the old ones from Protractor.
Fixes https://issues.redhat.com/projects/CONSOLE/issues/CONSOLE-2521.