Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1909043: Show an info instead of warning for flexible scaling on internal mode #7762

Merged
merged 1 commit into from Jan 13, 2021
Merged

Bug 1909043: Show an info instead of warning for flexible scaling on internal mode #7762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...components/ocs-install/attached-devices/create-sc/wizard-pages/review-and-create-step.tsx
View file
Open in desktop
Expand Up @@ -87,7 +87,7 @@ export const ReviewAndCreate: React.FC<ReviewAndCreateProps> = ({
</ReviewListBody>
<ReviewListBody
hideIcon={!enableFlexibleScaling || !stretchClusterChecked}
validation={enableFlexibleScaling && ValidationType.BAREMETAL_FLEXIBLE_SCALING}
validation={enableFlexibleScaling && ValidationType.ATTACHED_DEVICES_FLEXIBLE_SCALING}
>
<p>
{t('ceph-storage-plugin~{{zoneCount, number}} zone', {
Expand Down
2 changes: 1 addition & 1 deletion ...components/ocs-install/attached-devices/create-sc/wizard-pages/storage-and-nodes-step.tsx
View file
Open in desktop
Expand Up @@ -54,7 +54,7 @@ const validate = (
): ValidationType[] => {
const validations = [];
if (!enableStretchCluster && enableFlexibleScaling) {
validations.push(ValidationType.BAREMETAL_FLEXIBLE_SCALING);
validations.push(ValidationType.ATTACHED_DEVICES_FLEXIBLE_SCALING);
}
if (enableMinimal) {
validations.push(ValidationType.MINIMAL);
Expand Down
6 changes: 3 additions & 3 deletions frontend/packages/ceph-storage-plugin/src/utils/common-ocs-install-el.tsx
View file
Open in desktop
Expand Up @@ -41,7 +41,7 @@ export enum ValidationType {
'REQUIRED_FIELD_KMS' = 'REQUIRED_FIELD_KMS',
'NETWORK' = 'NETWORK',
'INTERNAL_FLEXIBLE_SCALING' = 'INTERNAL_FLEXIBLE_SCALING',
'BAREMETAL_FLEXIBLE_SCALING' = 'BAREMETAL_FLEXIBLE_SCALING',
'ATTACHED_DEVICES_FLEXIBLE_SCALING' = 'ATTACHED_DEVICES_FLEXIBLE_SCALING',
}

export const VALIDATIONS = (type: keyof typeof ValidationType, t: TFunction): Validation => {
Expand Down Expand Up @@ -121,12 +121,12 @@ export const VALIDATIONS = (type: keyof typeof ValidationType, t: TFunction): Va
};
case ValidationType.INTERNAL_FLEXIBLE_SCALING:
return {
variant: AlertVariant.warning,
variant: AlertVariant.info,
title: t(
'ceph-storage-plugin~The number of selected zones is less than the minimum requirement of 3. If not modified a host-based failure domain deployment will be enforced.',
),
};
case ValidationType.BAREMETAL_FLEXIBLE_SCALING:
case ValidationType.ATTACHED_DEVICES_FLEXIBLE_SCALING:
return {
variant: AlertVariant.info,
title: t(
Expand Down