New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1883614: Warn user when restarting BMH #7765
Bug 1883614: Warn user when restarting BMH #7765
Conversation
@rawagner: This pull request references Bugzilla bug 1883614, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rawagner: This pull request references Bugzilla bug 1883614, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8e3dd74
to
578ce06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small thing, but otherwise lgtm!
@@ -41,19 +39,12 @@ const RestartHostModal = ({ | |||
[host, close, handlePromise], | |||
); | |||
|
|||
const text = nodeName | |||
? t( | |||
'metal3-plugin~The bare metal host {{name}} will be restarted gracefully after all managed workloads are moved.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT of adding back a tiny bit of <p>
text above the warning that reads:
The host will be powered off and on again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's a bit obvious 🙂 but I think we typically have something in the body of modals explaining what's going to happen before warnings/alerts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, added!
578ce06
to
ccdaea5
Compare
/lgtm |
ccdaea5
to
d7018ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andybraren, jtomasek, rawagner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
@rawagner: All pull requests linked via external trackers have merged: Bugzilla bug 1883614 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@andybraren are you ok with the message ? (its the same as non-graceful poweroff)