Bug 1914209: Associate image secret name to pipeline serviceaccount imagePullSecrets

[karthikjeeyar]

Fixes:

https://issues.redhat.com/browse/ODC-5305

Analysis / Root cause:

While adding secret for image Registry in start pipeline model, the pipeline service account is missing the new secret name in the imagePullSecrets property.

Solution Description:

While adding Image Registry secret, associate the secret name to the imagePullSecrets on pipeline SA

Screen shots / Gifs for design review:

no UI changes

Unit test coverage report:

Test setup:

1. In start pipeline modal, Advanced Options -> Add Secret
2. Choose Image Registry option
3. Fill the details and click on create secret check button.

pipeline Service account should contain the newly created secret name in imagePullSecrets
eg:

apiVersion: v1
metadata:
 name: pipeline
 namespace: karthik
 uid: fc2e60f5-d42f-4ba7-82ee-e03be2cbe2a8
secrets:
 - name: pipeline-token-nk644
 - name: pipeline-dockercfg-p2jwc
 - name: image-secret
imagePullSecrets:
 - name: pipeline-dockercfg-p2jwc
 - name: image-secret

cc: @praveen4g0 @andrewballantyne

[karthikjeeyar]

/assign @jerolimov

[openshift-ci-robot]

@karthikjeeyar: This pull request references Bugzilla bug 1914209, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1914209: Associate image secret name to pipeline serviceaccount imagePullSecrets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[karthikjeeyar]

/kind bug

[openshift-ci-robot]

@karthikjeeyar: This pull request references Bugzilla bug 1914209, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1914209: Associate image secret name to pipeline serviceaccount imagePullSecrets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[divyanshiGupta]

Verified locally, works fine for me.
/lgtm

[invincibleJai]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyanshiGupta, invincibleJai, karthikjeeyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/pipelines-plugin/OWNERS [invincibleJai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@karthikjeeyar: All pull requests linked via external trackers have merged:

• openshift/console#7769

Bugzilla bug 1914209 has been moved to the MODIFIED state.

In response to this:

Bug 1914209: Associate image secret name to pipeline serviceaccount imagePullSecrets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.