Bug 1911465: Fix humanize IOPS function #7784
Conversation
openshift-ci-robot
added
the
bugzilla/severity-high
|
@bipuladh: This pull request references Bugzilla bug 1911465, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
openshift-ci-robot
added
the
approved
|
@bipuladh: This pull request references Bugzilla bug 1911465, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| return { | ||
| ...humanizedNumber, | ||
| string: `${humanizedNumber.value} ${unit}`, | ||
| unit, | ||
| string: `${humanizedNumber.string} IPOS`, |
There was a problem hiding this comment.
| string: `${humanizedNumber.string} IPOS`, | |
| string: `${humanizedNumber.string} IOPS`, |
| return { | ||
| ...humanizedNumber, | ||
| string: `${humanizedNumber.value} ${unit}`, | ||
| unit, | ||
| string: `${humanizedNumber.string} IPOS`, |
There was a problem hiding this comment.
Do string and unit both need to have IOPS unit?
There was a problem hiding this comment.
yes. Or else the two would not be consistent.
value + unit === string ( Format for humanize functions)
- Add the missing unit which was dropped initially
bipuladh
force-pushed
the
fix_iops_unit
branch
from
0be8306
to
2d19593
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh, cloudbehl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@bipuladh: All pull requests linked via external trackers have merged: Bugzilla bug 1911465 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Screenshot:
