Bug 1907660: Render pod list cell height correctly when pod names are long

[debsmita1]

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1907660

Solution Description:

• replaced the withUserSettingsCompatibility HOC with the useUserSettingsCompatibility hook

GIF:

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[openshift-ci-robot]

@debsmita1: This pull request references Bugzilla bug 1907660, which is invalid:

• expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1907660: Render pod list cell height correctly when pod names are long

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[debsmita1]

/kind bug

[debsmita1]

/bugzilla refresh

[openshift-ci-robot]

@debsmita1: This pull request references Bugzilla bug 1907660, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[debsmita1]

/cc @jerolimov
/cc @rhamilto

[jerolimov]

WOW. Impressed that this solves this issue, but it works great. Small request to keep the old default value.

[jerolimov]

Please keep the default as undefined so that this value are not stored in user settings configmap until the user changes the table config.

[jerolimov]

Please keep the default as undefined so that this value are not stored in user settings configmap until the user changes the table config.

[jerolimov]

Please keep the default as undefined so that this value are not stored in user settings configmap until the user changes the table config.

[jerolimov]

Please keep the default as undefined so that this value are not stored in user settings configmap until the user changes the table config.

[debsmita1]

/retest

[jerolimov]

Works fine. Tested resizing the window, changing the columns and switching between pages. Doesn't see the rendering-height-lag anymore. 👍

/lgtm

[jerolimov]

/assign @rhamilto @christianvogt

[rhamilto]

LGTM, but will wait on Christian for final approval.

[christianvogt]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, debsmita1, jerolimov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@debsmita1: All pull requests linked via external trackers have merged:

• openshift/console#7821

Bugzilla bug 1907660 has been moved to the MODIFIED state.

In response to this:

Bug 1907660: Render pod list cell height correctly when pod names are long

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.