Bug 1880389: fix skipped tasks in conditional pipelines

[andrewballantyne]

Big thanks to @karthikjeeyar for helping me with the legwork on this one. I'm hosting it as he is on PTO until the end of the week.

Fixes: https://issues.redhat.com/browse/ODC-4885

Needs to be back ported to 4.6 after this merges as it's a request from an external source.

Screenshots!

List view

Visualization (with and without the task skipped)

/cc @jerolimov @christianvogt
cc @bgliwa01 This probably overlaps some with 4.8 planned work.

[openshift-ci-robot]

@andrewballantyne: This pull request references Bugzilla bug 1880389, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1880389: fix skipped tasks in conditional pipelines

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerolimov]

/retest

[jerolimov]

Nit :)

Suggested change

	const isTaskSkipped = pipelineRun?.status?.skippedTasks
	? !!pipelineRun?.status?.skippedTasks.find((t) => t.name === task.name)
	: false;
	const isTaskSkipped = pipelineRun?.status?.skippedTasks?.some((t) => t.name === task.name);

[jerolimov]

@andrewballantyne Tested it locally and it works fine, but needs a rebase after some new i18n values. I expect you need one new also for "Skipped" status.

[jerolimov]

Works fine 👍

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, jerolimov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/pipelines-plugin/OWNERS [andrewballantyne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@andrewballantyne: All pull requests linked via external trackers have merged:

• openshift/console#7833

Bugzilla bug 1880389 has been moved to the MODIFIED state.

In response to this:

Bug 1880389: fix skipped tasks in conditional pipelines

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[andrewballantyne]

/cherry-pick release-4.6

[openshift-cherrypick-robot]

@andrewballantyne: #7833 failed to apply on top of branch "release-4.6":

Applying: fix skipped tasks in conditional pipelines
Using index info to reconstruct a base tree...
A	frontend/packages/pipelines-plugin/src/components/pipelines/detail-page-tabs/pipeline-details/PipelineVisualizationTask.tsx
A	frontend/packages/pipelines-plugin/src/components/pipelines/pipeline-topology/TaskNode.tsx
A	frontend/packages/pipelines-plugin/src/test-data/pipeline-data.ts
A	frontend/packages/pipelines-plugin/src/utils/__tests__/pipeline-augment.spec.ts
A	frontend/packages/pipelines-plugin/src/utils/__tests__/pipeline-filter-reducer.spec.ts
A	frontend/packages/pipelines-plugin/src/utils/pipeline-augment.ts
A	frontend/packages/pipelines-plugin/src/utils/pipeline-filter-reducer.ts
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): frontend/packages/pipelines-plugin/src/utils/pipeline-filter-reducer.ts deleted in HEAD and modified in fix skipped tasks in conditional pipelines. Version fix skipped tasks in conditional pipelines of frontend/packages/pipelines-plugin/src/utils/pipeline-filter-reducer.ts left in tree.
Auto-merging frontend/packages/dev-console/src/utils/pipeline-augment.ts
CONFLICT (content): Merge conflict in frontend/packages/dev-console/src/utils/pipeline-augment.ts
Auto-merging frontend/packages/dev-console/src/utils/__tests__/pipeline-filter-reducer.spec.ts
CONFLICT (content): Merge conflict in frontend/packages/dev-console/src/utils/__tests__/pipeline-filter-reducer.spec.ts
Auto-merging frontend/packages/dev-console/src/utils/__tests__/pipeline-augment.spec.ts
Auto-merging frontend/packages/dev-console/src/test/pipeline-data.ts
CONFLICT (content): Merge conflict in frontend/packages/dev-console/src/test/pipeline-data.ts
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix skipped tasks in conditional pipelines
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.