Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSOLE-2530: Migrate labels CRUD tests #7834

Merged
merged 1 commit into from Jan 22, 2021
Merged

CONSOLE-2530: Migrate labels CRUD tests #7834

merged 1 commit into from Jan 22, 2021

Conversation

rebeccaalpert
Copy link
Contributor

Migrated labels CRUD tests from Protractor to Cypress.

Fixes https://issues.redhat.com/projects/CONSOLE/issues/CONSOLE-2530.

spadgett
spadgett reviewed Jan 13, 2021
View reviewed changes
frontend/packages/integration-tests-cypress/tests/crud/labels.spec.ts Outdated Show resolved Hide resolved
frontend/packages/integration-tests-cypress/views/labels.ts Outdated
@@ -0,0 +1,6 @@
export const labels = {
inputLabel: (label: string) => cy.byTestID('tags-input').type(label),
confirmDetailsPageLabelExists: (label: string) => cy.get('.co-m-label__key').contains(label),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a test ID for this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the new test ID here?

frontend/packages/integration-tests-cypress/views/labels.ts Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Jan 13, 2021
@rebeccaalpert rebeccaalpert changed the title CONSOLE-2530: Migrate labels tests CONSOLE-2530: Migrate labels CRUD tests Jan 13, 2021
@rebeccaalpert
Copy link
Contributor Author

Addressed feedback and rebased.

spadgett
spadgett reviewed Jan 14, 2021
View reviewed changes
frontend/packages/integration-tests-cypress/tests/crud/labels.spec.ts Outdated
const plural = 'configmaps';
const kind = 'ConfigMap';
const labelValue = 'appblah';
const yaml = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const yaml = {
const yaml: ConfigMapKind = {

frontend/packages/integration-tests-cypress/views/labels.ts Outdated
@@ -0,0 +1,6 @@
export const labels = {
inputLabel: (label: string) => cy.byTestID('tags-input').type(label),
confirmDetailsPageLabelExists: (label: string) => cy.get('.co-m-label__key').contains(label),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the new test ID here?

@rebeccaalpert
Copy link
Contributor Author

Changes are all set.

/test e2e-gcp-console /test analyze

spadgett
spadgett approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 14, 2021
@spadgett
Copy link
Member

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2021
@spadgett
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

/hold
Looks like the label tests are failing.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2021
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2021
@rebeccaalpert
Copy link
Contributor Author

Test failure seemed to be caused by usage of cy.get instead of cy.byTestID. Cypress won't run for me locally right now, so I'll double check when I can get it going again.

@rebeccaalpert
Copy link
Contributor Author

Seems good now!

spadgett
spadgett approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebeccaalpert, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rebeccaalpert
Copy link
Contributor Author

/retest

2 similar comments
@spadgett
Copy link
Member

/retest

@rebeccaalpert
Copy link
Contributor Author

/retest

@rebeccaalpert rebeccaalpert removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2021
@rebeccaalpert
Copy link
Contributor Author

Removing the hold labels since this is now passing tests and doesn't require outside approvals.

@openshift-merge-robot openshift-merge-robot merged commit 5875791 into openshift:master Jan 22, 2021
@spadgett spadgett added this to the v4.7 milestone Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

@rhamilto rhamilto Awaiting requested review from rhamilto

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rebeccaalpert @spadgett @openshift-bot @openshift-ci-robot @openshift-merge-robot