Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken olm cypress tests and add them to CI script. #7835

Merged
merged 1 commit into from Jan 14, 2021
Merged

Fix broken olm cypress tests and add them to CI script. #7835

merged 1 commit into from Jan 14, 2021

Conversation

TheRealJon
Copy link
Member

Fix broken olm cypress tests and add them to CI script.

@openshift-ci-robot openshift-ci-robot added component/olm Related to OLM kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Jan 13, 2021
dtaylor113
dtaylor113 approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@dtaylor113 dtaylor113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2021
spadgett
spadgett approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2021
@benluddy benluddy mentioned this pull request Jan 13, 2021
Merged
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

@TheRealJon It looks like some of the OLM tests are running in the wrong perspective likely causing them to fail. It could be related to the user settings change to remember the last perspective.

@spadgett
Copy link
Member

@christianvogt It seems create operand in the admin perspective is switching the active perspective to dev. These tests are running in CI, so no one else should be using the cluster. Is this a bug?

@exdx exdx mentioned this pull request Jan 14, 2021
Merged
5 tasks
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2021
@andrewballantyne andrewballantyne mentioned this pull request Jan 14, 2021
Merged
spadgett
spadgett approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett spadgett mentioned this pull request Jan 14, 2021
Merged
@openshift-merge-robot openshift-merge-robot merged commit 8e1de0c into openshift:master Jan 14, 2021
@TheRealJon TheRealJon deleted the enable-ci-olm-cypress-tests branch January 15, 2021 04:32
@anik120 anik120 mentioned this pull request Jan 15, 2021
Merged
5 tasks
@spadgett spadgett added this to the v4.7 milestone Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@dtaylor113 dtaylor113 dtaylor113 approved these changes

@rhamilto rhamilto Awaiting requested review from rhamilto

Assignees

@spadgett spadgett

@dtaylor113 dtaylor113

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/olm Related to OLM kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@TheRealJon @openshift-bot @spadgett @openshift-ci-robot @dtaylor113 @openshift-merge-robot