Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1916834: Pipeline metrics text updates #7850

Merged
merged 1 commit into from Jan 21, 2021
Merged

Bug 1916834: Pipeline metrics text updates #7850

merged 1 commit into from Jan 21, 2021

Conversation

rottencandy
Copy link
Contributor

Fixes:
https://issues.redhat.com/browse/ODC-5310

Analysis / Root cause:

  • Pipeline Run should be capitalized in "Average pipeline run
  • It should be 2 of 2 succeeded not 2 succeeded of
  • In the tooltip of the donut chart, Success should be capitalized to follow sentence case

Solution Description:
Update the text

Screen shots / Gifs for design review:
scrt0
scrt1
cc: @openshift/team-devconsole-ux

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Jan 15, 2021
@rottencandy rottencandy changed the title Pipeline metrics text updates Bug 1916834: Pipeline metrics text updates Jan 15, 2021
@rottencandy
Copy link
Contributor Author

/kind bug

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 15, 2021
@openshift-ci-robot
Copy link
Contributor

@rottencandy: This pull request references Bugzilla bug 1916834, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1916834: Pipeline metrics text updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 15, 2021
@rottencandy
Copy link
Contributor Author

/cc @bgliwa01

abhinandan13jan
abhinandan13jan suggested changes Jan 19, 2021
View reviewed changes
...ges/pipelines-plugin/src/components/pipelines/pipeline-metrics/PipelineSuccessRatioDonut.tsx Outdated
y: parseFloat(percentage),
name: `${obj.x}: ${percentage}%`,
};
});
let successTimeSeriesObj = finalArray.reduce((acc, obj) => {
if (obj.x !== 'success') return acc;
if (obj.x !== 'Success') return acc;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use an enum for these checks?? something like Status.Success

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not able to find an existing enum for pipeline graph axes. Should I create one?
Not sure if it's required since we only check for the Success axis here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not very necessary, but it would be really good, if you can store this string const successString = 'Success' in a variable as it is being checked in multiple places, IMO

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

rohitkrai03
rohitkrai03 suggested changes Jan 20, 2021
View reviewed changes
...ges/pipelines-plugin/src/components/pipelines/pipeline-metrics/PipelineSuccessRatioDonut.tsx Outdated
@@ -36,6 +36,7 @@ const PipelineSuccessRatioDonut: React.FC<PipelineMetricsGraphProps> = ({
delay: interval,
});
const pipelineSuccessData = runData?.data?.result ?? [];
const successString = 'Success';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to capitalize this string? I don't see it being rendered anywhere. You wouldn't have to explicitly capitalize strings in the obj to check for it's equality if you just kept it success.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used by the donut chart component on hover. I realized It could be capitalized directly inside the component itself. Updated.

rohitkrai03
rohitkrai03 approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rohitkrai03, rottencandy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bgliwa01
Copy link

In the first image, what is the black box that says pipeline success ratio?

@openshift-merge-robot openshift-merge-robot merged commit fdda66e into openshift:master Jan 21, 2021
@openshift-ci-robot
Copy link
Contributor

@rottencandy: All pull requests linked via external trackers have merged:

Bugzilla bug 1916834 has been moved to the MODIFIED state.

In response to this:

Bug 1916834: Pipeline metrics text updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Jan 26, 2021
@rottencandy rottencandy deleted the pipelinemetrics branch February 8, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinandan13jan abhinandan13jan abhinandan13jan requested changes

@rohitkrai03 rohitkrai03 rohitkrai03 approved these changes

@debsmita1 debsmita1 Awaiting requested review from debsmita1

@bgliwa01 bgliwa01 Awaiting requested review from bgliwa01

Assignees

@rohitkrai03 rohitkrai03

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. kind/bug Categorizes issue or PR as related to a bug. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@rottencandy @openshift-ci-robot @openshift-bot @bgliwa01 @rohitkrai03 @abhinandan13jan @spadgett @openshift-merge-robot