Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1917585: Clean up olm i18n and catch some missed translations. #7858

Merged
merged 1 commit into from Jan 21, 2021
Merged

Bug 1917585: Clean up olm i18n and catch some missed translations. #7858

merged 1 commit into from Jan 21, 2021

Conversation

TheRealJon
Copy link
Member

Remove unused i18n namespaces and add some missed translations in the OperatorHub subscribe page.

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Jan 18, 2021
@openshift-ci-robot openshift-ci-robot added component/olm Related to OLM kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Jan 18, 2021
@spadgett
Copy link
Member 

ERROR in ./packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-subscribe.tsx
Module not found: Error: Can't resolve 'packages/console-shared/src' in '/go/src/github.com/openshift/console/frontend/packages/operator-lifecycle-manager/src/components/operator-hub'

spadgett
spadgett reviewed Jan 18, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @TheRealJon. We should either open a Bugzilla to track this change or associate it with a story.

...d/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-subscribe.tsx Outdated Show resolved Hide resolved
...d/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-subscribe.tsx Outdated Show resolved Hide resolved
...d/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-subscribe.tsx Outdated Show resolved Hide resolved
...d/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-subscribe.tsx Outdated Show resolved Hide resolved
...d/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-subscribe.tsx Outdated Show resolved Hide resolved
@TheRealJon TheRealJon changed the title Clean up olm i18n and catch some missed translations. CONSOLE-2371: Clean up olm i18n and catch some missed translations. Jan 18, 2021
spadgett
spadgett approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2021
@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 18, 2021
@spadgett
Copy link
Member

spadgett commented Jan 18, 2021 •
edited by openshift-ci-robot

Hey @TheRealJon, CONSOLE-2371 is already marked as done... I'd probably open a BZ if we missed some strings.

@spadgett
Copy link
Member

/lgtm cancel
Looks like you need to run yarn i18n

@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 18, 2021
@TheRealJon
Copy link
Member Author

TheRealJon commented Jan 18, 2021 •
edited

/lgtm cancel
Looks like you need to run yarn i18n

@spadgett Oops, yep forgot that. Fixed now.

spadgett
spadgett approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 18, 2021
@TheRealJon TheRealJon changed the title CONSOLE-2371: Clean up olm i18n and catch some missed translations. Bug 1917585: Clean up olm i18n and catch some missed translations. Jan 18, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 18, 2021
@openshift-ci-robot
Copy link
Contributor

@TheRealJon: This pull request references Bugzilla bug 1917585, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1917585: Clean up olm i18n and catch some missed translations.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TheRealJon
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 18, 2021
@openshift-ci-robot
Copy link
Contributor

@TheRealJon: This pull request references Bugzilla bug 1917585, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 18, 2021
@spadgett
Copy link
Member

/retest
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2021
@spadgett spadgett added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2021
@spadgett
Copy link
Member

@TheRealJon Needs rebase :/

@TheRealJon
Clean up olm i18n and catch some missed translations.
8d1f463 
Remove unused namespaces and add some missed translations in the OperatorHub subscribe page.
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2021
spadgett
spadgett approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3c6b47b into openshift:master Jan 21, 2021
@openshift-ci-robot
Copy link
Contributor

@TheRealJon: All pull requests linked via external trackers have merged:

Bugzilla bug 1917585 has been moved to the MODIFIED state.

In response to this:

Bug 1917585: Clean up olm i18n and catch some missed translations.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TheRealJon TheRealJon deleted the olm-i18n-fixes branch January 21, 2021 14:24
@spadgett spadgett added this to the v4.7 milestone Jan 21, 2021
@openshift-ci-robot openshift-ci-robot mentioned this pull request Jan 25, 2021
Merged
@bipuladh bipuladh mentioned this pull request Jan 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@kyoto kyoto Awaiting requested review from kyoto

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/olm Related to OLM kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TheRealJon @spadgett @openshift-ci-robot @openshift-bot @openshift-merge-robot