Fix to show CRW icon when CRW operator is installed #7895
Conversation
openshift-ci-robot
added
kind/bug
divyanshiGupta
changed the title
|
/assign @rohitkrai03 |
openshift-ci-robot
added
the
approved
There was a problem hiding this comment.
Tested this on a cluster 4.7.0-0.nightly-2021-01-21-215614 with CodeReady Workspaces 2.5.1.
Needed to accept an insecure https connection to see the icon which is a test-cluster issue. Everything else works as expected and code looks also fine.
Great to see some additional tests here 👍
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyanshiGupta, jerolimov, rohitkrai03 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Fixes: https://issues.redhat.com/browse/ODC-4939
Analysis/Root cause:
CHE icon is shown instead of CRW icon even when CRW operator is installed because a static CHE icon was being returned in both the cases.
Solution:
Use ConsoleLink CR to get the correct icon.
Screenshot:
Unit test Coverage:
PR test setup:
Install CRW operator.
Go to CRW operator details page and create CRW cluster.
After all the pods are running check if the ConsoleLink CR has been created.
Once the CR is created, you should be able to see the icon.
/kind bug