Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1919396: Fixed a11y violation for Deployment Config Details Pod Status ring #7907

Merged
merged 1 commit into from Jan 25, 2021
Merged

Bug 1919396: Fixed a11y violation for Deployment Config Details Pod Status ring #7907

merged 1 commit into from Jan 25, 2021

Conversation

dtaylor113
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Jan 22, 2021
@openshift-ci-robot
Copy link
Contributor

@dtaylor113: This pull request references Bugzilla bug 1919396, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1919396: Fixed a11y violation for Deployment Config Details Pod Status ring

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 22, 2021
@openshift-ci-robot openshift-ci-robot added the component/shared Related to console-shared label Jan 22, 2021
spadgett
spadgett reviewed Jan 25, 2021
View reviewed changes
frontend/packages/console-shared/src/components/pod/PodStatus.tsx Outdated
@@ -97,6 +97,7 @@ const PodStatus: React.FC<PodStatusProps> = ({
duration: ANIMATION_DURATION,
onEnd: updateOnEnd ? forceUpdate : undefined,
}}
ariaTitle={`${truncTitle} ${truncSubTitle}`} // ex: '3 pods' or '3 Scaling to 2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use the untruncated value for screen readers? Presumably it's truncated because it won't fit inside the donut. Here we don't have that problem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thanks

@dtaylor113 dtaylor113 force-pushed the depolyment_config_details_a11y_fix branch from 75d50a9 to 16fe8c4 Compare January 25, 2021 15:14
spadgett
spadgett reviewed Jan 25, 2021
View reviewed changes
frontend/packages/console-shared/src/components/pod/PodStatus.tsx Outdated
@@ -124,19 +125,21 @@ const PodStatus: React.FC<PodStatusProps> = ({
/>
);
}, [
updateOnEnd,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this changed from an editor quick fix, but it would be better to keep this list alphabetized like before.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thanks

@dtaylor113 dtaylor113 force-pushed the depolyment_config_details_a11y_fix branch from 16fe8c4 to 3482f75 Compare January 25, 2021 16:00
spadgett
spadgett reviewed Jan 25, 2021
View reviewed changes
frontend/packages/console-shared/src/components/pod/PodStatus.tsx
@@ -129,6 +130,8 @@ const PodStatus: React.FC<PodStatusProps> = ({
outerRadius,
size,
standalone,
title,
subTitle,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: alpha, this should go below truncSubTitle

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arrg, sorry, thanks again! I hate Mondays :-)

@dtaylor113 dtaylor113 force-pushed the depolyment_config_details_a11y_fix branch from 3482f75 to eda9796 Compare January 25, 2021 16:19
spadgett
spadgett approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 25, 2021
@openshift-merge-robot openshift-merge-robot merged commit d792c61 into openshift:master Jan 25, 2021
@openshift-ci-robot
Copy link
Contributor

@dtaylor113: All pull requests linked via external trackers have merged:

Bugzilla bug 1919396 has been moved to the MODIFIED state.

In response to this:

Bug 1919396: Fixed a11y violation for Deployment Config Details Pod Status ring

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

@kyoto kyoto Awaiting requested review from kyoto

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtaylor113 @openshift-ci-robot @spadgett @openshift-merge-robot