New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1919851: fix pipeline visualization with same pipeline & task name #7910
Bug 1919851: fix pipeline visualization with same pipeline & task name #7910
Conversation
/kind bug |
@karthikjeeyar: This pull request references Bugzilla bug 1919851, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, karthikjeeyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
@karthikjeeyar: All pull requests linked via external trackers have merged: Bugzilla bug 1919851 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.6 |
@andrewballantyne: new pull request created: #7927 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-5357
Analysis / Root cause:
Sharing the same name for a pipeline and one of its tasks, does not render the visualization and adding additional tasks breaks the pipeline details page.
Solution Description:
Pipeline visualization graph ID must be different from the node(task) ID. Id's used in the topology should be unique.
Screen shots / Gifs for design review:
Before fix (pipeline with same name as task name):
After fix (pipeline with same name as task name):
Pipeline with an extra task
Test setup:
Browser conformance: