Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1918112: Fix custom flavor editing when no template flavors exist #7922

Merged
merged 1 commit into from Jan 29, 2021
Merged

Bug 1918112: Fix custom flavor editing when no template flavors exist #7922

merged 1 commit into from Jan 29, 2021

Conversation

pcbailey
Copy link
Contributor

This PR fixes an issue that causes the CPU and memory values for custom flavors to be uneditable in the edit flavor modal when a non-custom flavor is selected and no flavors are available in the template.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. labels Jan 25, 2021
@openshift-ci-robot
Copy link
Contributor

@pcbailey: This pull request references Bugzilla bug 1918112, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

WIP: Bug 1918112: Fix custom flavor editing when no template flavors exist

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin labels Jan 25, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2021
@pcbailey pcbailey changed the title WIP: Bug 1918112: Fix custom flavor editing when no template flavors exist Bug 1918112: Fix custom flavor editing when no template flavors exist Jan 26, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2021
@yaacov
Copy link
Member

yaacov commented Jan 26, 2021

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 26, 2021
@openshift-ci-robot
Copy link
Contributor

@yaacov: This pull request references Bugzilla bug 1918112, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pcbailey pcbailey force-pushed the allow-editing-custom-flavor branch 2 times, most recently from 18477c5 to 12a3793 Compare January 27, 2021 22:45
@yaacov
Copy link
Member

yaacov commented Jan 28, 2021

/retest

@yaacov
Copy link
Member

yaacov commented Jan 28, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yaacov
Copy link
Member

yaacov commented Jan 28, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@yaacov
Copy link
Member

yaacov commented Jan 29, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit 61f5429 into openshift:master Jan 29, 2021
@openshift-ci-robot
Copy link
Contributor

@pcbailey: All pull requests linked via external trackers have merged:

Bugzilla bug 1918112 has been moved to the MODIFIED state.

In response to this:

Bug 1918112: Fix custom flavor editing when no template flavors exist

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Feb 1, 2021
@pcbailey pcbailey deleted the allow-editing-custom-flavor branch October 26, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mareklibra mareklibra Awaiting requested review from mareklibra

@atiratree atiratree Awaiting requested review from atiratree

Assignees

@yaacov yaacov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pcbailey @openshift-ci-robot @yaacov @openshift-bot @spadgett @openshift-merge-robot