New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1920674: Fix missingKey errors #7937
Bug 1920674: Fix missingKey errors #7937
Conversation
@rebeccaalpert: This pull request references Bugzilla bug 1920674, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@rebeccaalpert: This pull request references Bugzilla bug 1920674, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't new, but I have one suggestion on the text to be the different binding types more clear.
The bindings namespace had various missingKey errors due to usage of i18next.t. I updated the code to use the correct approach. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1920674
276c2ed
to
b3db0ab
Compare
All set @spadgett. |
/test e2e-gcp-console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rebeccaalpert, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rebeccaalpert: All pull requests linked via external trackers have merged: Bugzilla bug 1920674 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The bindings namespace had various missingKey errors due to usage of i18next.t. I updated the code to use the correct approach.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1920674.