Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flakiness in OCS Operator Installation test #7942

Merged
merged 1 commit into from Jan 28, 2021
Merged

Fix flakiness in OCS Operator Installation test #7942

merged 1 commit into from Jan 28, 2021

Conversation

bipuladh
Copy link
Contributor

  • Add a reload before going to the storage Cluster Creation Page

@bipuladh
Fix flakiness in OCS Operator Installation test
420fea6 
 - Add a reload before going to the storage Cluster Creation Page
@openshift-ci-robot openshift-ci-robot added the component/ceph Related to ceph-storage-plugin label Jan 27, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2021
cloudbehl
cloudbehl reviewed Jan 27, 2021
View reviewed changes
frontend/packages/ceph-storage-plugin/integration-tests-cypress/support/index.ts
Comment on lines +53 to +56
// Reload because StorageCluster CRD is not registered in the UI; hence getting 404 Error
cy.visit('/');
cy.reload(true);
commonFlows.navigateToOCS();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen this happening after reload as well lot of times. Can we add some 20sec and do a reload?

@cloudbehl
Copy link
Contributor

/test e2e-gcp-console
/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, cloudbehl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2021
@cloudbehl
Copy link
Contributor

/test e2e-gcp-console

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9fbc0ee into openshift:master Jan 28, 2021
@spadgett spadgett added this to the v4.7 milestone Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudbehl cloudbehl cloudbehl left review comments

@afreen23 afreen23 Awaiting requested review from afreen23

@rawagner rawagner Awaiting requested review from rawagner

Assignees

@cloudbehl cloudbehl

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bipuladh @cloudbehl @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot