Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1921087: Next quick start link update #7945

Merged
merged 1 commit into from Feb 5, 2021
Merged

Bug 1921087: Next quick start link update #7945

merged 1 commit into from Feb 5, 2021

Conversation

abhinandan13jan
Copy link
Contributor

Addresses

https://issues.redhat.com/browse/ODC-5349

Issue

'start next quick start' link doesn't work and is unintuitive
If the next quick start is not installed, then the link doesn't actually work.
It's also not clear to the user as to what the next quick start is since it shows the ID of the quick start and not the quick start label.

Screenshots

quickstartnext

Tests

Updates QuickStartContent and QuickStartConclusion

Browser conformance

Chrome

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Jan 27, 2021
@openshift-ci-robot openshift-ci-robot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Jan 27, 2021
@abhinandan13jan abhinandan13jan changed the title Next quick start link update Bug 1921087: Next quick start link update Jan 27, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 27, 2021
@openshift-ci-robot
Copy link
Contributor

@abhinandan13jan: This pull request references Bugzilla bug 1921087, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1921087: Next quick start link update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhinandan13jan
Copy link
Contributor Author

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 27, 2021
jerolimov
jerolimov suggested changes Jan 29, 2021
View reviewed changes
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the benefit of not adding a second prop for nextQuickStart. Wdyt?

frontend/packages/console-app/src/components/quick-starts/QuickStartPanelContent.tsx Outdated
Comment on lines 70 to 75
quickStart={quickStart}
quickStart={{ ...quickStart, nextQuickStarts }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmm, why you don't added a second prop nextQuickStarts here and in the QuickStartController?

frontend/packages/console-app/src/components/quick-starts/QuickStartController.tsx Outdated
@@ -5,7 +5,7 @@ import QuickStartFooter from './controller/QuickStartFooter';
import { QuickStartContext, QuickStartContextValues } from './utils/quick-start-context';

type QuickStartControllerProps = {
quickStart: QuickStart;
quickStart: QuickStart & { nextQuickStarts?: QuickStart[] };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not a second nextQuickStarts prop here? Any benefit of reusing a QuickStart object which is now a common QuickStart object?

Suggested change
quickStart: QuickStart & { nextQuickStarts?: QuickStart[] };
quickStart: QuickStart;
nextQuickStarts?: QuickStart[];

frontend/packages/console-app/src/components/quick-starts/controller/QuickStartContent.tsx Outdated
@@ -7,7 +7,7 @@ import QuickStartConclusion from './QuickStartConclusion';
import './QuickStartContent.scss';

type QuickStartContentProps = {
quickStart: QuickStart;
quickStart: QuickStart & { nextQuickStarts?: QuickStart[] };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
quickStart: QuickStart & { nextQuickStarts?: QuickStart[] };
quickStart: QuickStart;
nextQuickStarts?: QuickStart[];

frontend/packages/console-app/src/components/quick-starts/controller/QuickStartContent.tsx Outdated
@@ -21,10 +21,11 @@ const QuickStartContent = React.forwardRef<HTMLDivElement, QuickStartContentProp
ref,
) => {
const {
spec: { introduction, tasks, conclusion, nextQuickStart = [] },
nextQuickStarts = [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract it from the props instead

@spadgett
Copy link
Member

/override ci/prow/ceph-storage-plugin

The ceph-storage-plugin job should only have run on PRs with changes to frontend/packages/ceph-storage-plugin. It failed due to an unrelated CI config change. Overriding status on this PR.

@openshift-ci-robot
Copy link
Contributor

@spadgett: Overrode contexts on behalf of spadgett: ci/prow/ceph-storage-plugin

In response to this:

/override ci/prow/ceph-storage-plugin

The ceph-storage-plugin job should only have run on PRs with changes to frontend/packages/ceph-storage-plugin. It failed due to an unrelated CI config change. Overriding status on this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added component/ceph Related to ceph-storage-plugin component/dev-console Related to dev-console component/insights Related to insights plugin component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/monitoring Related to monitoring component/shared Related to console-shared labels Feb 1, 2021
@abhinandan13jan abhinandan13jan force-pushed the next-quick-start branch 2 times, most recently from 284f20c to 86b08e7 Compare February 1, 2021 12:20
invincibleJai
invincibleJai reviewed Feb 1, 2021
View reviewed changes
frontend/packages/console-app/src/components/quick-starts/QuickStartPanelContent.tsx Outdated Show resolved Hide resolved
frontend/packages/console-app/src/components/quick-starts/QuickStartController.tsx
@@ -6,12 +6,14 @@ import { QuickStartContext, QuickStartContextValues } from './utils/quick-start-

type QuickStartControllerProps = {
quickStart: QuickStart;
nextQuickStarts?: QuickStart[];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this to be a list or just QuickStart ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quickStart could have multple nextQuickStarts as dependencies. Although we only make use of the first one as of today. But, lets not lose this data for future needs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should show all the next quick starts. Can you make that change and just loop over all the next quick starts to render all of them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 agree... if we have it we should show it. Maybe that's a 4.8 thing and not part of this bug though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is ready for re-review with single nextQuickStart @rohitkrai03 @invincibleJai

rohitkrai03
rohitkrai03 suggested changes Feb 1, 2021
View reviewed changes
frontend/packages/console-app/src/components/quick-starts/QuickStartController.tsx
@@ -6,12 +6,14 @@ import { QuickStartContext, QuickStartContextValues } from './utils/quick-start-

type QuickStartControllerProps = {
quickStart: QuickStart;
nextQuickStarts?: QuickStart[];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should show all the next quick starts. Can you make that change and just loop over all the next quick starts to render all of them?

@invincibleJai
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2021
@christianvogt
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2021
jerolimov
jerolimov approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2021
@nemesis09
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinandan13jan, christianvogt, invincibleJai, jerolimov, nemesis09

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 7afffa8 into openshift:master Feb 5, 2021
@openshift-ci-robot
Copy link
Contributor

@abhinandan13jan: All pull requests linked via external trackers have merged:

Bugzilla bug 1921087 has been moved to the MODIFIED state.

In response to this:

Bug 1921087: Next quick start link update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Feb 6, 2021
@jschuler jschuler mentioned this pull request Mar 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewballantyne andrewballantyne andrewballantyne left review comments

@rohitkrai03 rohitkrai03 rohitkrai03 requested changes

@jerolimov jerolimov jerolimov approved these changes

@dtaylor113 dtaylor113 Awaiting requested review from dtaylor113

@kyoto kyoto Awaiting requested review from kyoto

@invincibleJai invincibleJai Awaiting requested review from invincibleJai

@debsmita1 debsmita1 Awaiting requested review from debsmita1

Assignees

@jerolimov jerolimov

@invincibleJai invincibleJai

@nemesis09 nemesis09

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dev-console Related to dev-console component/insights Related to insights plugin component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/monitoring Related to monitoring component/shared Related to console-shared kind/bug Categorizes issue or PR as related to a bug. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet