[release-4.6] Bug 1921603: Fix crash when loaded is true but the data set doesn't include the pods #7985

jerolimov · 2021-01-29T20:03:32Z

Fixes:
https://issues.redhat.com/browse/OCPBUGSM-23911
https://bugzilla.redhat.com/show_bug.cgi?id=1921603

Analysis / Root cause:
The console components fetches two sets of data to show a DeploymentConfig (or DeamonSet or StatefulSet) with the correlated Pods. The Pod status donut was shown as soon as the data are "loaded". But in some situations the pod data are not available in this moment. This can happen if the Pod is already deleted (see PR #6689) or if the loading of the pods needs to fetch more then "one page". With the default page size this means more than 250 Pods.

In PR #6689 we fixed this already for Deployments but didn't changed this in the three similar code based for the resource types mention above.

Solution Description:
Similar to PR #6689:

Show the loading indicator only as long as the first page is loaded and loaded is true.
Do not render the Pod donut when there are no data are available.

Screen shots / Gifs for design review:
Nothing changed.

Unit test coverage report:
Nothing changed.

Test setup:

Create a relevant list of DeploymentConfigs (6+, as mentioned Deployments are already fixed!)

#!/bin/bash
for ((i = 1; i <= 40; i++)); do
    echo Create nodeinfo-$i
    oc new-app jerolimov/nodeinfo --name nodeinfo-$i
    sleep 10
done

Change the paginationLimit in frontend/public/actions/k8s.ts to 5.
Open a DeploymentConfig in the developer perspective which needs to fetch at least two pages for fetch the right Pods.

If you are unsure open all detail pages for all ~10 DeploymentConfigs on your local development environment.

To completely reproduce this on a shared cluster you will need more then 250 DeploymentConfigs... :-/

Browser conformance:

Chrome
Firefox
Safari
Edge

openshift-ci-robot · 2021-01-29T20:03:36Z

@jerolimov: This pull request references Bugzilla bug 1921603, which is invalid:

expected the bug to target the "4.6.z" release, but it targets "4.7.0" instead
expected Bugzilla bug 1921603 to depend on a bug targeting a release in 4.7.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.6] Bug 1921603: Fix crash when loaded is true but the data set doesn't include the pods

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jerolimov · 2021-01-29T20:05:31Z

/bugzilla refresh
/assign @christianvogt

openshift-ci-robot · 2021-01-29T20:05:34Z

@jerolimov: This pull request references Bugzilla bug 1921603, which is invalid:

expected Bugzilla bug 1921603 to depend on a bug targeting a release in 4.7.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh
/assign @christianvogt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jerolimov · 2021-01-29T20:53:05Z

/bugzilla refresh

openshift-ci-robot · 2021-01-29T20:53:08Z

@jerolimov: This pull request references Bugzilla bug 1921603, which is invalid:

expected dependent Bugzilla bug 1922475 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is CLOSED (CURRENTRELEASE) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jerolimov · 2021-01-29T20:54:12Z

/bugzilla refresh

openshift-ci-robot · 2021-01-29T20:54:19Z

@jerolimov: This pull request references Bugzilla bug 1921603, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1922475 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1922475 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jerolimov · 2021-01-29T20:55:15Z

/kind bug

christianvogt · 2021-02-01T15:21:14Z

/approve

rohitkrai03

/lgtm

openshift-ci-robot · 2021-02-01T16:20:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, jerolimov, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [christianvogt,rohitkrai03]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2021-02-02T14:41:01Z

@jerolimov: This pull request references Bugzilla bug 1921603, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1922475 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1922475 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
bug has dependents

In response to this:

[release-4.6] Bug 1921603: Fix crash when loaded is true but the data set doesn't include the pods

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-03T22:15:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-03T22:41:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-03T23:07:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-03T23:20:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-04T09:57:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-04T10:10:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-04T10:23:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-04T10:36:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-04T10:49:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

jerolimov · 2021-02-04T11:00:37Z

Backend crash depends on #8025. Hold this until the other PR got merged to reduce unnecessary test loops here.

/hold

jerolimov · 2021-02-05T10:29:57Z

/unhold
/test backend

openshift-bot · 2021-02-05T10:52:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-05T12:24:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

jerolimov · 2021-02-05T13:18:26Z

@knobunc this PR (and others) depends on #8025, can you cherry-pick-approve this as well so that we can rerun the backend tests again? Thanks :)

openshift-bot · 2021-02-05T14:21:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-05T14:47:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-05T15:00:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-05T15:13:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

jerolimov · 2021-02-05T15:54:57Z

/hold

jerolimov · 2021-02-05T16:30:12Z

#8025 is now merged, we can try to run the tests again.
/unhold
/test backend

openshift-bot · 2021-02-05T16:31:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

knobunc · 2021-02-05T17:24:26Z

[As patch-manager] Pulling the cherry-pick-approval since the PR didn't make the merge window... sorry. Please resolve the CI problems so it can make next week's window.

openshift-bot · 2021-02-05T17:49:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-02-11T02:00:58Z

@jerolimov: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-gcp-console	`7e5ab13`	link	`/test e2e-gcp-console`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-02-11T02:01:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2021-02-11T03:01:39Z

@jerolimov: All pull requests linked via external trackers have merged:

openshift/console#7985

Bugzilla bug 1921603 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1921603: Fix crash when loaded is true but the data set doesn't include the pods

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Fix crash when loaded is true but the data set doesn't include the pods

7e5ab13

openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Jan 29, 2021

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 29, 2021

openshift-ci-robot requested review from jhadvig and spadgett January 29, 2021 20:04

openshift-ci-robot added the component/core Related to console core functionality label Jan 29, 2021

openshift-ci-robot assigned christianvogt Jan 29, 2021

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 29, 2021

openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 29, 2021

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2021

rohitkrai03 approved these changes Feb 1, 2021

View reviewed changes

openshift-ci-robot assigned rohitkrai03 Feb 1, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2021

knobunc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 3, 2021

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2021

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2021

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2021

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2021

knobunc removed the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 5, 2021

bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 10, 2021

openshift-merge-robot merged commit 91c7257 into openshift:release-4.6 Feb 11, 2021

spadgett added this to the v4.6.z milestone Mar 18, 2021

[release-4.6] Bug 1921603: Fix crash when loaded is true but the data set doesn't include the pods #7985

[release-4.6] Bug 1921603: Fix crash when loaded is true but the data set doesn't include the pods #7985

Conversation

jerolimov commented Jan 29, 2021 • edited

openshift-ci-robot commented Jan 29, 2021

jerolimov commented Jan 29, 2021

openshift-ci-robot commented Jan 29, 2021

jerolimov commented Jan 29, 2021

openshift-ci-robot commented Jan 29, 2021

jerolimov commented Jan 29, 2021

openshift-ci-robot commented Jan 29, 2021

jerolimov commented Jan 29, 2021

christianvogt commented Feb 1, 2021

rohitkrai03 left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Feb 1, 2021

openshift-ci-robot commented Feb 2, 2021

openshift-bot commented Feb 3, 2021

openshift-bot commented Feb 3, 2021

openshift-bot commented Feb 3, 2021

openshift-bot commented Feb 3, 2021

openshift-bot commented Feb 4, 2021

openshift-bot commented Feb 4, 2021

openshift-bot commented Feb 4, 2021

openshift-bot commented Feb 4, 2021

openshift-bot commented Feb 4, 2021

jerolimov commented Feb 4, 2021

jerolimov commented Feb 5, 2021

openshift-bot commented Feb 5, 2021

openshift-bot commented Feb 5, 2021

jerolimov commented Feb 5, 2021 • edited

openshift-bot commented Feb 5, 2021

openshift-bot commented Feb 5, 2021

openshift-bot commented Feb 5, 2021

openshift-bot commented Feb 5, 2021

jerolimov commented Feb 5, 2021

jerolimov commented Feb 5, 2021 • edited

openshift-bot commented Feb 5, 2021

knobunc commented Feb 5, 2021

openshift-bot commented Feb 5, 2021

openshift-ci bot commented Feb 11, 2021

openshift-bot commented Feb 11, 2021

openshift-ci-robot commented Feb 11, 2021

jerolimov commented Jan 29, 2021 •

edited

jerolimov commented Feb 5, 2021 •

edited

jerolimov commented Feb 5, 2021 •

edited