-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1923081: Improve test for checking common templates #8001
Bug 1923081: Improve test for checking common templates #8001
Conversation
@gouyang: This pull request references Bugzilla bug 1923081, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@gouyang: This pull request references Bugzilla bug 1923081, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/lgtm cancel |
const flavor = vmtName.split('-')[2]; | ||
|
||
await browser.wait(until.presenceOf(templateView.defaultOSLabel)); | ||
expect(await templateView.workload(`openshift-${vmtName}`).getText()).toContain(workload); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expect(await templateView.workload(`openshift-${vmtName}`).getText()).toContain(workload); | |
expect(await (templateView.workload(`openshift-${vmtName}`) as any).getText()).toContain(workload); |
|
||
await browser.wait(until.presenceOf(templateView.defaultOSLabel)); | ||
expect(await templateView.workload(`openshift-${vmtName}`).getText()).toContain(workload); | ||
const detailFlavor = await templateView.flavor(`openshift-${vmtName}`).getText(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const detailFlavor = await templateView.flavor(`openshift-${vmtName}`).getText(); | |
const detailFlavor = await (templateView.flavor(`openshift-${vmtName}`) as any).getText(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yaacov Thanks, it works in this way.
721b880
to
9754720
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gouyang, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@gouyang: All pull requests linked via external trackers have merged: Bugzilla bug 1923081 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Verified in https://cnv-qe-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/test-kubevirt-[console-4](https://issues.redhat.com/browse/console-4).7-cnv-2.6/31/console