Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1923081: Improve test for checking common templates #8001

Merged
merged 1 commit into from Feb 2, 2021
Merged

Bug 1923081: Improve test for checking common templates #8001

merged 1 commit into from Feb 2, 2021

Conversation

gouyang
Copy link
Contributor

@gouyang gouyang commented Feb 1, 2021 •
edited by openshift-ci-robot

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. labels Feb 1, 2021
@openshift-ci-robot
Copy link
Contributor

@gouyang: This pull request references Bugzilla bug 1923081, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1923081: Improve test for checking common templates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@gouyang: This pull request references Bugzilla bug 1923081, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1923081: Improve test for checking common templates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin labels Feb 1, 2021
@rawagner
Copy link
Contributor

rawagner commented Feb 1, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 1, 2021
@yaacov
Copy link
Member

yaacov commented Feb 1, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@rawagner
Copy link
Contributor

rawagner commented Feb 1, 2021

/lgtm cancel
failing build

@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 1, 2021
yaacov
yaacov reviewed Feb 1, 2021
View reviewed changes
frontend/packages/kubevirt-plugin/integration-tests/tests/vmtemplate.wizard.scenario.ts Outdated
const flavor = vmtName.split('-')[2];

await browser.wait(until.presenceOf(templateView.defaultOSLabel));
expect(await templateView.workload(`openshift-${vmtName}`).getText()).toContain(workload);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
expect(await templateView.workload(`openshift-${vmtName}`).getText()).toContain(workload);
expect(await (templateView.workload(`openshift-${vmtName}`) as any).getText()).toContain(workload);

yaacov
yaacov reviewed Feb 1, 2021
View reviewed changes
frontend/packages/kubevirt-plugin/integration-tests/tests/vmtemplate.wizard.scenario.ts Outdated

await browser.wait(until.presenceOf(templateView.defaultOSLabel));
expect(await templateView.workload(`openshift-${vmtName}`).getText()).toContain(workload);
const detailFlavor = await templateView.flavor(`openshift-${vmtName}`).getText();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const detailFlavor = await templateView.flavor(`openshift-${vmtName}`).getText();
const detailFlavor = await (templateView.flavor(`openshift-${vmtName}`) as any).getText();

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaacov Thanks, it works in this way.

@yaacov
Copy link
Member

yaacov commented Feb 2, 2021

/lgtm
/retest

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gouyang, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 2, 2021
@gouyang
Copy link
Contributor Author

gouyang commented Feb 2, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit 9bcdef5 into openshift:master Feb 2, 2021
@openshift-ci-robot
Copy link
Contributor

@gouyang: All pull requests linked via external trackers have merged:

Bugzilla bug 1923081 has been moved to the MODIFIED state.

In response to this:

Bug 1923081: Improve test for checking common templates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Feb 5, 2021
@gouyang gouyang deleted the common_template branch February 7, 2021 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaacov yaacov yaacov left review comments

@irosenzw irosenzw Awaiting requested review from irosenzw

@rhrazdil rhrazdil Awaiting requested review from rhrazdil

Assignees

@rawagner rawagner

@yaacov yaacov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@gouyang @openshift-ci-robot @rawagner @yaacov @openshift-bot @spadgett @openshift-merge-robot