Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove anonymous exports in NADs plugin #8005

Conversation

pcbailey
Copy link
Contributor

@pcbailey pcbailey commented Feb 1, 2021

This PR removes anonymous exports in the network attachment definitions plugin.

@pcbailey
Copy link
Contributor Author

pcbailey commented Feb 1, 2021

@yaacov Could you please review?

@openshift-ci-robot openshift-ci-robot added component/network-attachment-definition Related to network-attachment-definition approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 1, 2021
@yaacov
Copy link
Member

yaacov commented Feb 1, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yaacov
Copy link
Member

yaacov commented Feb 1, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0d7a96f into openshift:master Feb 1, 2021
@spadgett spadgett added this to the v4.7 milestone Feb 5, 2021
@pcbailey pcbailey deleted the remove-anonymous-exports-in-nads-plugin branch October 26, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/network-attachment-definition Related to network-attachment-definition lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants