Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1923911: improve test for vm filter and details page #8014

Merged

Conversation

gouyang
Copy link
Contributor

@gouyang gouyang commented Feb 2, 2021

Notes for reviewer:

  1. Rewrite test for vm details page, use VM created from common template instead of a mock one as common templates are more common for testing purpose.
  2. Change verify pending VM to importing VM, importing is more common status than pending.

Verified in https://cnv-qe-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/test-kubevirt-[console-4](https://issues.redhat.com/browse/console-4).7-cnv-2.6-gouyang/14/console

@openshift-ci-robot
Copy link
Contributor

@gouyang: This pull request references Bugzilla bug 1923911, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1923911: improve test for vm filter and details page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@gouyang: This pull request references Bugzilla bug 1923911, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1923911: improve test for vm filter and details page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin labels Feb 2, 2021
@gouyang
Copy link
Contributor Author

gouyang commented Feb 2, 2021

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2021
@gouyang gouyang force-pushed the improve_cdi_filter_details branch 2 times, most recently from a983d50 to 1cdf72d Compare February 4, 2021 08:27
@gouyang
Copy link
Contributor Author

gouyang commented Feb 4, 2021

@gouyang
Copy link
Contributor Author

gouyang commented Feb 4, 2021

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2021
@gouyang
Copy link
Contributor Author

gouyang commented Feb 4, 2021

@yaacov @rawagner @glekner PTAL

@yaacov
Copy link
Member

yaacov commented Feb 4, 2021

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gouyang, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 4, 2021
@openshift-merge-robot openshift-merge-robot merged commit 7779e97 into openshift:master Feb 4, 2021
@openshift-ci-robot
Copy link
Contributor

@gouyang: All pull requests linked via external trackers have merged:

Bugzilla bug 1923911 has been moved to the MODIFIED state.

In response to this:

Bug 1923911: improve test for vm filter and details page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Feb 5, 2021
@gouyang gouyang deleted the improve_cdi_filter_details branch February 7, 2021 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants