Bug 1923939: add missing trigger types and update the optional fields - 4.6

[karthikjeeyar]

This is a manual cherry pick of #7889

Fixes: https://issues.redhat.com/browse/ODC-5350 in 4.6

Analysis / Root cause:
Event listeners has an optional triggerRef field which is not compatible in UI code causes the UI to crash

Solution Description:
Add the missing trigger types such as triggerRef and update the checks for optional fields.

Test setup:

apiVersion: triggers.tekton.dev/v1alpha1
kind: EventListener
metadata:
  name: vote-app
spec:
  serviceAccountName: pipeline
  triggers:
    - triggerRef: vote-app

This fixes the UI Crashing when above yaml is used.
cc: @andrewballantyne

[openshift-ci-robot]

@karthikjeeyar: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

4.6 fix trigger ref

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@karthikjeeyar: This pull request references Bugzilla bug 1923939, which is invalid:

• expected dependent Bugzilla bug 1918639 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1923939: add missing trigger types and update the optional fields - 4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[karthikjeeyar]

/kind bug

[karthikjeeyar]

/test backend

[karthikjeeyar]

/retest

[karthikjeeyar]

/retest

[openshift-ci-robot]

@karthikjeeyar: This pull request references Bugzilla bug 1923939, which is invalid:

• expected dependent Bugzilla bug 1918639 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1923939: add missing trigger types and update the optional fields - 4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[invincibleJai]

/retest

[spadgett]

You will need #8025 for the backend tests to pass.

[karthikjeeyar]

Thanks @spadgett for the information.

/hold

[karthikjeeyar]

/bugzilla refresh

[openshift-ci-robot]

@karthikjeeyar: This pull request references Bugzilla bug 1923939, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.z) matches configured target release for branch (4.6.z)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1918639 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
• dependent Bugzilla bug 1918639 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
• bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[invincibleJai]

/lgtm
/approve

Verified on PR build and am not seeing issue with Event listener with triggerRef creation

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, karthikjeeyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [invincibleJai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[spadgett]

/hold cancel

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@karthikjeeyar: All pull requests linked via external trackers have merged:

• openshift/console#8015

Bugzilla bug 1923939 has been moved to the MODIFIED state.

In response to this:

Bug 1923939: add missing trigger types and update the optional fields - 4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.