New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1923951: fixes eveting menuoptions for create flow for all namespace selection #8016
Bug 1923951: fixes eveting menuoptions for create flow for all namespace selection #8016
Conversation
frontend/packages/knative-plugin/src/components/eventing/__tests__/EventingListPage.spec.tsx
Outdated
Show resolved
Hide resolved
bd73afa
to
4a7a39c
Compare
verified this locally |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: debsmita1, invincibleJai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@invincibleJai: This pull request references Bugzilla bug 1923951, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@invincibleJai: All pull requests linked via external trackers have merged: Bugzilla bug 1923951 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-5457
Analysis / Root cause:
for all namespace selection if user create from admin perspective for EventSources / Channels then namespace dropdown on create flow shows undefined
Solution Description:
Added check for namespace in case of all namespace selects default namespace
Unit test coverage report:
Browser conformance: