Bug 1924078: Make Topology quick search View all results footer sticky #8029
Conversation
openshift-ci-robot
added
the
bugzilla/severity-low
|
@jeff-phillips-18: This pull request references Bugzilla bug 1924078, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@jeff-phillips-18: This pull request references Bugzilla bug 1924078, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -1,9 +1,9 @@ | |||
| .odc-quick-search-content { | |||
| height: calc(100% - 60px); | |||
| flex: 1; | |||
|
/cc @divyanshiGupta |
|
/kind bug |
openshift-ci-robot
added
the
kind/bug
|
/approve Verified changes , works as expected |
openshift-ci-robot
added
the
approved
|
verified the changes |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: debsmita1, invincibleJai, jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jeff-phillips-18: All pull requests linked via external trackers have merged: Bugzilla bug 1924078 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-5402
Analysis / Root cause:
The link to all results was added to the data list rather than being a separate component and styling the list to be scrollable.
Solution Description:
Make the all results link a component separate from the list. Update the layout to allow the list to scroll rather than the entire left side area. Use flex display for modal rather than setting an adjusted percentage height on the search content.
Screen shots / Gifs for design review:
Browser conformance: