Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1920677: Fix for i18n for dev console guided tour #8032

Merged
merged 1 commit into from Feb 4, 2021
Merged

Bug 1920677: Fix for i18n for dev console guided tour #8032

merged 1 commit into from Feb 4, 2021

Conversation

jeff-phillips-18
Copy link
Member

Fixes:
https://issues.redhat.com/browse/OCPBUGSM-23788

Analysis / Root cause:
Guided tour plugin used i18next.t rather than the %<string>% format for getting localized strings.

Solution Description:
Update to use the %<string>% format.

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

/kind bug

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. labels Feb 2, 2021
@openshift-ci-robot
Copy link
Contributor

@jeff-phillips-18: This pull request references Bugzilla bug 1920677, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1920677: Fix for i18n for dev console guided tour

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 2, 2021
@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Feb 2, 2021
@invincibleJai
Copy link
Member

/retest

@invincibleJai
Copy link
Member

invincibleJai commented Feb 3, 2021 •
edited

@jeff-phillips-18 we have some miss in cloudShellConfirmationModal where i18n.t is used as well, it falls under console-app though.

and these seems issue with frontend CI

invincibleJai
invincibleJai reviewed Feb 3, 2021
View reviewed changes
frontend/packages/dev-console/src/components/guided-tour/index.ts
@@ -11,50 +10,47 @@ const getSelector = (id: string): string => `[data-tour-id="${id}"]`;

export const getGuidedTour = (): TourDataType => ({
intro: {
heading: i18n.t('devconsole~Welcome to the Developer Perspective!'),
heading: '%devconsole~Welcome to the Developer Perspective!%',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in plugin we even have comments along with % , is that not needed

Suggested change
heading: '%devconsole~Welcome to the Developer Perspective!%',
// t('devconsole~Welcome to the Developer Perspective!')
heading: '%devconsole~Welcome to the Developer Perspective!%',

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Feb 3, 2021
@invincibleJai
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2021
@jeff-phillips-18
Copy link
Member Author

/test e2e-gcp-console

@christianvogt
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, invincibleJai, jeff-phillips-18

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2021
@openshift-merge-robot openshift-merge-robot merged commit 7a508eb into openshift:master Feb 4, 2021
@openshift-ci-robot
Copy link
Contributor

@jeff-phillips-18: All pull requests linked via external trackers have merged:

Bugzilla bug 1920677 has been moved to the MODIFIED state.

In response to this:

Bug 1920677: Fix for i18n for dev console guided tour

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Feb 5, 2021
@openshift-ci-robot openshift-ci-robot mentioned this pull request Feb 19, 2021
Merged
@jeff-phillips-18 jeff-phillips-18 deleted the i18n-fix branch January 4, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invincibleJai invincibleJai invincibleJai left review comments

@sahil143 sahil143 Awaiting requested review from sahil143

@abhinandan13jan abhinandan13jan Awaiting requested review from abhinandan13jan

@karthikjeeyar karthikjeeyar Awaiting requested review from karthikjeeyar

Assignees

@invincibleJai invincibleJai

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/dev-console Related to dev-console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jeff-phillips-18 @openshift-ci-robot @invincibleJai @christianvogt @spadgett @openshift-merge-robot