New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1925516: Pipeline metrics tooltips #8062
Bug 1925516: Pipeline metrics tooltips #8062
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Verified it works fine. Will add lgtm once the conflict is resolved. |
7133d50
to
fec7916
Compare
/lgtm |
fec7916
to
9dcf44c
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, bgliwa01, karthikjeeyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@andrewballantyne: This pull request references Bugzilla bug 1925516, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@andrewballantyne: All pull requests linked via external trackers have merged: Bugzilla bug 1925516 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
For https://issues.redhat.com/browse/ODC-5311
A hacky implementation to try and make tooltips expand upwards from a chart. They have PF examples (css-overflow) of this but they neglect to mention that it doesn't stop the tooltip from going off the side of the browser and get chopped off. Which is very easily done on the Pipeline Metrics page.
The solution is adding height to the chart, a negative margin to bring it back & constraining the tooltip so it doesn't go outside of the side bounds of the chart.
Browser Support
Works on...