Bug 1925596: Text overflows Card boundary; Add Commit msg to details

[keithchong]

Signed-off-by: Keith Chong kykchong@redhat.com

See GitOps 611.

[keithchong]

Solution. Text will truncate and when hovering over the text, hover/tool tip will appear to show the entire string. Added commit message because it will be useful to have and is more meaningful.

[keithchong]

/test frontend

[keithchong]

Fixes #8067

[divyanshiGupta]

@keithchong since we are adding truncation for image name and commit details in this PR it will be great if we can add truncation and tooltip for environment name too as this will fix this issue https://issues.redhat.com/browse/ODC-4876 based on comment https://issues.redhat.com/browse/ODC-4876?focusedCommentId=15133883&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-15133883. Thanks!

cc: @lwrigh

[keithchong]

Hi @divyanshiGupta , I can work on the fix for that. However, I propose we create a separate PR for that so as to not hold up these changes, since they are independent. Also, note the time constraints we have (I find testing will take up some time)

[divyanshiGupta]

@keithchong I am fine with creating another PR for adding truncation to env name.

@lwrigh what do you think?

[lwrigh]

The truncation in the labels looks good to me.

[keithchong]

@divyanshiGupta , I'm not sure why the test failed. Doesn't seem related to the changes.

[divyanshiGupta]

@keithchong it says this i18n files are not up to date. Commit them to fix.. Try running yarn i18n and then push the changes.

[rohitkrai03]

/retitle Bug 1925596: Text overflows Card boundary; Add Commit msg to details

[openshift-ci-robot]

@keithchong: This pull request references Bugzilla bug 1925596, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1925596: Text overflows Card boundary; Add Commit msg to details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rohitkrai03]

/assign

[rohitkrai03]

/lgtm
/approve

Tested locally. Works as expected.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: keithchong, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/gitops-plugin/OWNERS [rohitkrai03]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@keithchong: All pull requests linked via external trackers have merged:

• openshift/console#8064

Bugzilla bug 1925596 has been moved to the MODIFIED state.

In response to this:

Bug 1925596: Text overflows Card boundary; Add Commit msg to details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.