Add storage.bind.immediate.requested annotation to golden image dvs #8085
Conversation
openshift-ci-robot
added
the
approved
|
/lgtm |
openshift-ci-robot
added
lgtm
| dv.metadata = dv?.metadata || {}; | ||
| dv.metadata.annotations = { | ||
| ...(dv?.metadata?.annotations || {}), | ||
| 'cdi.kubevirt.io/storage.bind.immediate.requested': 'true', |
There was a problem hiding this comment.
dv fixture already has the annotation https://github.com/openshift/console/blob/master/frontend/packages/kubevirt-plugin/integration-tests-cypress/fixtures/data-volume.json#L8
yaacov
force-pushed
the
add-storage.bind.immediate.requested-annotaion-to-golden-image-dvs
branch
from
59b866e
to
c7d3829
Compare
yaacov
force-pushed
the
add-storage.bind.immediate.requested-annotaion-to-golden-image-dvs
branch
from
12c00a7
to
ee9b18a
Compare
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rawagner, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/cherry-pick release-4.7 |
|
@yaacov: new pull request created: #8109 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When adding a golden image, we want it to get created immediately without waiting for first consumer