[release-4.6] Bug 1931515: allow choice of binding type when creating RoleBinding #8212

rhamilto · 2021-02-22T15:59:20Z

Manual back port of Bug 1927882 as 4.7 includes other fixes that are not part of 4.6.

Note this reverts part of the changes in Bug 1871996.

Manual back port of Bug 1927882 as 4.7 includes other fixes that are not part of 4.6. Note this reverts part of the changes in Bug 1871996.

openshift-ci-robot · 2021-02-22T15:59:25Z

@rhamilto: This pull request references Bugzilla bug 1931515, which is invalid:

expected dependent Bugzilla bug 1929198 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead
expected dependent Bugzilla bug 1927882 to target a release in 4.7.0, but it targets "4.8.0" instead
expected dependent Bugzilla bug 1929198 to target a release in 4.7.0, but it targets "4.7.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spadgett

/lgtm

openshift-ci-robot · 2021-02-22T17:14:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [rhamilto,spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-02-23T01:00:50Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-23T01:00:54Z

@openshift-bot: This pull request references Bugzilla bug 1931515, which is invalid:

expected dependent Bugzilla bug 1929198 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead
expected dependent Bugzilla bug 1927882 to target a release in 4.7.0, but it targets "4.8.0" instead
expected dependent Bugzilla bug 1929198 to target a release in 4.7.0, but it targets "4.7.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-24T01:01:00Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-24T01:01:05Z

@openshift-bot: This pull request references Bugzilla bug 1931515, which is invalid:

expected dependent Bugzilla bug 1929198 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead
expected dependent Bugzilla bug 1927882 to target a release in 4.7.0, but it targets "4.8.0" instead
expected dependent Bugzilla bug 1929198 to target a release in 4.7.0, but it targets "4.7.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-25T01:00:17Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-25T01:00:27Z

@openshift-bot: This pull request references Bugzilla bug 1931515, which is invalid:

expected dependent Bugzilla bug 1929198 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead
expected dependent Bugzilla bug 1927882 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-26T01:00:30Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-26T01:00:37Z

@openshift-bot: This pull request references Bugzilla bug 1931515, which is invalid:

expected dependent Bugzilla bug 1929198 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead
expected dependent Bugzilla bug 1927882 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-27T01:00:41Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-27T01:00:47Z

@openshift-bot: This pull request references Bugzilla bug 1931515, which is invalid:

expected dependent Bugzilla bug 1929198 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
expected dependent Bugzilla bug 1927882 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-28T01:00:52Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-28T01:00:56Z

@openshift-bot: This pull request references Bugzilla bug 1931515, which is invalid:

expected dependent Bugzilla bug 1929198 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
expected dependent Bugzilla bug 1927882 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-01T01:00:42Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-01T01:00:48Z

@openshift-bot: This pull request references Bugzilla bug 1931515, which is invalid:

expected dependent Bugzilla bug 1929198 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
expected dependent Bugzilla bug 1927882 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-02T01:00:38Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-02T01:00:43Z

@openshift-bot: This pull request references Bugzilla bug 1931515, which is invalid:

expected dependent Bugzilla bug 1929198 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
expected dependent Bugzilla bug 1927882 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-03T01:01:04Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-03T01:01:09Z

@openshift-bot: This pull request references Bugzilla bug 1931515, which is invalid:

expected dependent Bugzilla bug 1929198 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
expected dependent Bugzilla bug 1927882 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-04T01:00:52Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-04T01:00:57Z

@openshift-bot: This pull request references Bugzilla bug 1931515, which is invalid:

expected dependent Bugzilla bug 1929198 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
expected dependent Bugzilla bug 1927882 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-05T01:00:31Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-05T01:00:36Z

@openshift-bot: This pull request references Bugzilla bug 1931515, which is invalid:

expected dependent Bugzilla bug 1929198 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
expected dependent Bugzilla bug 1927882 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-06T01:01:22Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-06T01:01:27Z

@openshift-bot: This pull request references Bugzilla bug 1931515, which is invalid:

expected dependent Bugzilla bug 1929198 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
expected dependent Bugzilla bug 1927882 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-07T01:01:14Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-07T01:01:19Z

@openshift-bot: This pull request references Bugzilla bug 1931515, which is invalid:

expected dependent Bugzilla bug 1929198 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
expected dependent Bugzilla bug 1927882 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-08T01:01:14Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-08T01:01:20Z

@openshift-bot: This pull request references Bugzilla bug 1931515, which is invalid:

expected dependent Bugzilla bug 1929198 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
expected dependent Bugzilla bug 1927882 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-09T01:01:08Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-09T01:01:12Z

@openshift-bot: This pull request references Bugzilla bug 1931515, which is invalid:

expected dependent Bugzilla bug 1929198 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
expected dependent Bugzilla bug 1927882 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-10T01:00:47Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-10T01:00:52Z

@openshift-bot: This pull request references Bugzilla bug 1931515, which is invalid:

expected dependent Bugzilla bug 1929198 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
expected dependent Bugzilla bug 1927882 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-11T01:01:05Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-11T01:01:09Z

@openshift-bot: This pull request references Bugzilla bug 1931515, which is invalid:

expected dependent Bugzilla bug 1927882 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-12T01:39:48Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-12T01:39:52Z

@openshift-bot: This pull request references Bugzilla bug 1931515, which is invalid:

expected dependent Bugzilla bug 1927882 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhamilto · 2021-03-12T13:14:08Z

/bugzilla refresh

openshift-ci-robot · 2021-03-12T13:14:16Z

@rhamilto: This pull request references Bugzilla bug 1931515, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1929198 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1929198 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
bug has dependents

Requesting review from QA contact:
/cc @yapei

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-03-17T19:35:46Z

@rhamilto: All pull requests linked via external trackers have merged:

openshift/console#8212

Bugzilla bug 1931515 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Bug 1931515: allow choice of binding type when creating RoleBinding

fbac52a

Manual back port of Bug 1927882 as 4.7 includes other fixes that are not part of 4.6. Note this reverts part of the changes in Bug 1871996.

rhamilto assigned spadgett Feb 22, 2021

openshift-ci-robot requested review from dtaylor113 and kyoto February 22, 2021 15:59

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2021

spadgett approved these changes Feb 22, 2021

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2021

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 12, 2021

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 12, 2021

openshift-ci-robot requested a review from yapei March 12, 2021 13:14

ecordell added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 17, 2021

openshift-merge-robot merged commit d142eea into openshift:release-4.6 Mar 17, 2021

rhamilto deleted the bz1931515 branch March 17, 2021 19:37

spadgett added this to the v4.6.z milestone Mar 18, 2021

[release-4.6] Bug 1931515: allow choice of binding type when creating RoleBinding #8212

[release-4.6] Bug 1931515: allow choice of binding type when creating RoleBinding #8212

Conversation

rhamilto commented Feb 22, 2021

openshift-ci-robot commented Feb 22, 2021

spadgett left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Feb 22, 2021

openshift-bot commented Feb 23, 2021

openshift-ci-robot commented Feb 23, 2021

openshift-bot commented Feb 24, 2021

openshift-ci-robot commented Feb 24, 2021

openshift-bot commented Feb 25, 2021

openshift-ci-robot commented Feb 25, 2021

openshift-bot commented Feb 26, 2021

openshift-ci-robot commented Feb 26, 2021

openshift-bot commented Feb 27, 2021

openshift-ci-robot commented Feb 27, 2021

openshift-bot commented Feb 28, 2021

openshift-ci-robot commented Feb 28, 2021

openshift-bot commented Mar 1, 2021

openshift-ci-robot commented Mar 1, 2021

openshift-bot commented Mar 2, 2021

openshift-ci-robot commented Mar 2, 2021

openshift-bot commented Mar 3, 2021

openshift-ci-robot commented Mar 3, 2021

openshift-bot commented Mar 4, 2021

openshift-ci-robot commented Mar 4, 2021

openshift-bot commented Mar 5, 2021

openshift-ci-robot commented Mar 5, 2021

openshift-bot commented Mar 6, 2021

openshift-ci-robot commented Mar 6, 2021

openshift-bot commented Mar 7, 2021

openshift-ci-robot commented Mar 7, 2021

openshift-bot commented Mar 8, 2021

openshift-ci-robot commented Mar 8, 2021

openshift-bot commented Mar 9, 2021

openshift-ci-robot commented Mar 9, 2021

openshift-bot commented Mar 10, 2021

openshift-ci-robot commented Mar 10, 2021

openshift-bot commented Mar 11, 2021

openshift-ci-robot commented Mar 11, 2021

openshift-bot commented Mar 12, 2021

openshift-ci-robot commented Mar 12, 2021

rhamilto commented Mar 12, 2021

openshift-ci-robot commented Mar 12, 2021

openshift-ci-robot commented Mar 17, 2021