Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gherkin Script:Getting Started - Spring Boot-ODC-4389 #8362

Merged
merged 1 commit into from Mar 19, 2021
Merged

Gherkin Script:Getting Started - Spring Boot-ODC-4389 #8362

merged 1 commit into from Mar 19, 2021

Conversation

sanketpathak
Copy link
Contributor

Problem: Need an easy getting started experience for Spring Boot developers.
Story: https://issues.redhat.com/browse/ODC-5442
Epic: https://issues.redhat.com/browse/ODC-4389

@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Mar 10, 2021
@openshift-ci-robot openshift-ci-robot added the component/knative Related to knative-plugin label Mar 10, 2021
gajanan-more
gajanan-more suggested changes Mar 11, 2021
View reviewed changes
frontend/packages/dev-console/integration-tests/features/addFlow/upload-JAR-file.feature Outdated
@@ -0,0 +1,157 @@
Feature: UploadJAR file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add @add-flow at the top of the file? WDYT @makambalaji

frontend/packages/dev-console/integration-tests/features/addFlow/upload-JAR-file.feature Outdated
And user clicks on Browse in JAR file section
And user selects file to upload
And user selects appropriate Build image version
And user gives Application name as "sample-upload-app" and Name as "<name>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
And user gives Application name as "sample-upload-app" and Name as "<name>"
And user gives Application Groupings name as "sample-upload-app" and workload Name as "<name>"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes more sense and won't confuse anyone. WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

frontend/packages/dev-console/integration-tests/features/addFlow/upload-JAR-file.feature Outdated Show resolved Hide resolved
frontend/packages/dev-console/integration-tests/features/addFlow/upload-JAR-file.feature Outdated Show resolved Hide resolved
.../packages/dev-console/integration-tests/features/topology/topology-chart-area-visual.feature Outdated Show resolved Hide resolved
.../packages/dev-console/integration-tests/features/topology/topology-chart-area-visual.feature Outdated Show resolved Hide resolved
.../packages/dev-console/integration-tests/features/topology/topology-chart-area-visual.feature Outdated Show resolved Hide resolved
...d/packages/dev-console/integration-tests/features/topology/topology-editing-app-node.feature Outdated Show resolved Hide resolved
frontend/packages/dev-console/integration-tests/features/topology/topology-list-view.feature Outdated Show resolved Hide resolved
...d/packages/knative-plugin/integration-tests/features/knative/create-knative-workload.feature Outdated Show resolved Hide resolved
@sanketpathak sanketpathak force-pushed the Getting-Started-Spring-Boot-ODC-4389 branch from ecbdf8c to d710ce6 Compare March 11, 2021 14:32
@sanketpathak sanketpathak force-pushed the Getting-Started-Spring-Boot-ODC-4389 branch from d710ce6 to 725804d Compare March 12, 2021 12:33
christianvogt
christianvogt reviewed Mar 12, 2021
View reviewed changes
frontend/packages/dev-console/integration-tests/features/addFlow/upload-JAR-file.feature Outdated
And user selects file to upload
And user gives Application name as "sample-upload-app" and workload Name as "sample-yaml-upload"
And user clicks "Build Configuration" link in Advanced Options section
And user unselects Configure a webhook build trigger checkbox in build configuration section
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These options aren't available for upload a jar flow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

.../packages/dev-console/integration-tests/features/topology/topology-chart-area-visual.feature Outdated
Comment on lines 232 to 236
Scenario: Drag and drop Incompatible file in topology chart view
Given user has a incompatible file
And user is at the Topology chart view
When user drags and drop the file on topology
Then the curser will show the action is not available
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not possible. The user must first drop the file before we can validate it.

UX wants to display a toast warning message that the file is invalid.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added about the toast warning message

frontend/packages/dev-console/integration-tests/features/topology/topology-list-view.feature Outdated


@regression, @manual
Scenario: Drag and drop Incompatible file in topology chart view
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there are duplicate scripts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it's for the list view. I'll correct the scenario name

@sanketpathak sanketpathak force-pushed the Getting-Started-Spring-Boot-ODC-4389 branch from 725804d to c003667 Compare March 15, 2021 18:31
christianvogt
christianvogt reviewed Mar 15, 2021
View reviewed changes
frontend/packages/dev-console/integration-tests/features/topology/topology-list-view.feature Outdated
Given user has a incompatible file
And user is at the Topology list view
When user drags and drop the file on topology
Then the curser will show the action is not available
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar update needed here to show a toast.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

.../packages/dev-console/integration-tests/features/topology/topology-chart-area-visual.feature


@regression @manual
Scenario: Add to Project through drag and drop to upload JAR file in topology
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This scenario is a bit redundant with the one above it considering the difference has already been tested as part of the form tests. The interaction with topology is the same.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand but we need to consider all the scenario as part of epic

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose. I'm not sure of your overall strategy.
IMO testing topology doesn't require re-testing the different form flows. As long as one of the flows works.

@sanketpathak sanketpathak force-pushed the Getting-Started-Spring-Boot-ODC-4389 branch from c003667 to 1e4b552 Compare March 16, 2021 12:46
@christianvogt
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2021
makambalaji
makambalaji reviewed Mar 17, 2021
View reviewed changes
Copy link
Contributor

@makambalaji makambalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add @Manual tag, only if we are not able to automate the scenario
Add the @to-do for all the scenarios wherever automation possible

frontend/packages/dev-console/integration-tests/features/addFlow/upload-JAR-file.feature Show resolved Hide resolved
frontend/packages/dev-console/integration-tests/features/addFlow/upload-JAR-file.feature Show resolved Hide resolved
frontend/packages/dev-console/integration-tests/features/addFlow/upload-JAR-file.feature Show resolved Hide resolved
.../packages/dev-console/integration-tests/features/topology/topology-chart-area-visual.feature Show resolved Hide resolved
frontend/packages/dev-console/integration-tests/features/topology/topology-list-view.feature Outdated
And user has selected namespace "aut-topology-list-view"


@regression, @smoke
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's a smoke test, please remove @regression tag

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

frontend/packages/dev-console/integration-tests/features/topology/topology-list-view.feature Outdated
@regression, @manual
Scenario: View shortcuts menu
Given user has uploaded a jar file
When user clicks on View shortcuts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which page, do we see this shortcuts menu?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Topology list view page

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please mention that in when condition

Suggested change
When user clicks on View shortcuts
When user clicks on View shortcuts in topology list view

...d/packages/knative-plugin/integration-tests/features/knative/create-knative-workload.feature Outdated


@regression @manual
Scenario Outline: knative resource type in upload JAR file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be Scenario, when there is no examples

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@sanketpathak sanketpathak force-pushed the Getting-Started-Spring-Boot-ODC-4389 branch 2 times, most recently from 8a6a50a to 4fe0bbd Compare March 19, 2021 07:41
@sanketpathak sanketpathak force-pushed the Getting-Started-Spring-Boot-ODC-4389 branch from 4fe0bbd to b0a9827 Compare March 19, 2021 07:50
@makambalaji
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, makambalaji, sanketpathak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b677346 into openshift:master Mar 19, 2021
@spadgett spadgett added this to the v4.8 milestone Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianvogt christianvogt christianvogt left review comments

@makambalaji makambalaji makambalaji left review comments

@gajanan-more gajanan-more gajanan-more requested changes

@mgencur mgencur Awaiting requested review from mgencur

Assignees

@makambalaji makambalaji

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/knative Related to knative-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sanketpathak @christianvogt @makambalaji @openshift-ci-robot @gajanan-more @spadgett @openshift-merge-robot