Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(bug-fix): Fixes donut chart loading #8383

Merged
merged 1 commit into from Mar 15, 2021
Merged

(bug-fix): Fixes donut chart loading #8383

merged 1 commit into from Mar 15, 2021

Conversation

afreen23
Copy link
Contributor

  • fixes available disk info
  • used node names for request on localvolumediscoveryresults

Before:
before

After:
after

(bug-fix): Fixes donut chart loading
f92ee55 
 -  fixes available disk info
 -  used node names for request on localvolumediscoveryresults

Signed-off-by: Afreen Rahman <afrahman@redhat.com>
@afreen23
Copy link
Contributor Author

/kind bug

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. component/ceph Related to ceph-storage-plugin labels Mar 15, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2021
@Jayashree-panda
Copy link
Contributor

Jayashree-panda commented Mar 15, 2021 •
edited

/lgtm tested and worked!

@openshift-ci-robot
Copy link
Contributor

@Jayashree-panda: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bipuladh
bipuladh approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@bipuladh bipuladh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, bipuladh, Jayashree-panda

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 803eb00 into openshift:master Mar 15, 2021
@spadgett spadgett added this to the v4.8 milestone Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bipuladh bipuladh bipuladh approved these changes

@shyRozen shyRozen Awaiting requested review from shyRozen

Assignees

@bipuladh bipuladh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@afreen23 @Jayashree-panda @openshift-ci-robot @openshift-bot @bipuladh @spadgett @openshift-merge-robot